Skip to content

Add Spanish and German - #4

Merged
et-nik merged 1 commit into
mainfrom
0917-de-and-es-langs
Sep 17, 2026
Merged

et-nik merged 1 commit into
mainfrom
0917-de-and-es-langs

Conversation

@et-nik

@et-nik et-nik commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Added Spanish and German language support across FTP/SFTP user administration, configuration, access controls, and validation messages.
    • Added localized labels for navigation, actions, empty states, errors, and server capabilities.
  • Tests

    • Added translation integrity checks to ensure all supported languages include the required English keys and preserve placeholder tokens.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 175f1c26-b4cd-4726-8031-fd13ba6a4ff2

📥 Commits

Reviewing files that changed from the base of the PR and between afbf5d4 and 887551d.

📒 Files selected for processing (4)
  • frontend/src/__tests__/translations.spec.ts
  • frontend/src/translations/de.ts
  • frontend/src/translations/es.ts
  • frontend/src/translations/index.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • gameap/gameap.github.io (manual)

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.


📝 Walkthrough

Walkthrough

The frontend adds German and Spanish translation catalogs, registers both locales, exports them, and tests key and placeholder consistency against English.

Changes

Translation locales

Layer / File(s) Summary
Translation catalogs and registry
frontend/src/translations/de.ts, frontend/src/translations/es.ts, frontend/src/translations/index.ts
Adds German and Spanish FTP/SFTP administration translations. Registers both catalogs and exports them with the existing locales.
Translation integrity validation
frontend/src/__tests__/translations.spec.ts
Adds Vitest checks for matching translation keys and {placeholder} or :placeholder tokens across locales.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 88755

German and Spanish catalogs are registered with the expected locale codes and preserve the English translation contract. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding Spanish and German translations.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@et-nik
et-nik merged commit c939b13 into main Sep 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant