Repository navigation
Define native Workbench IPC profile - #1048
Merged
Merged
Conversation
✅ Deploy Preview for angry-raman-7c44f6 canceled.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39fb2db10f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Reject ambiguous grant inventories before project selection. Keep distinct-ID admission separate from structural row uniqueness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define the exact opt-in
morphir/workbench/native0.1.0-draft.1mapping for page-bound desktop IPC, immutable evaluation jobs and read-only OS-picked workspace grants. The native descriptor contains the frozen jobs offer directly. Per-call trusted caller checks, revocation, transfer retirement and explicit unknown-effect errors avoid treating renderer labels or HTTP-shaped private frames as authority.Add three closed schemas and 210 independently authored structural cases to the existing Workbench schema gate. Preserve connected v1 and the frozen HTTP host, jobs and terminal contracts. Expand the exact frozen submission/initial-reply shapes within the native schemas to avoid nondeterministic optimized-validator failures under nested operation conditionals.
Include 16 raw-input rejection expectations and 15 lifecycle traces as explicitly unexecuted parent-owned data. Shared Rust MCK execution, public adapter adoption and packaged OS/architecture qualification remain follow-up work; the existing MoonBit private bootstrap does not advertise this public profile.
Validation: full
mise run workbench:schema-check, all 210 native cases on five consecutive fresh validator runs,mise run fmt-check, JSON syntax/fixture-ID checks and independent semantic review. No runtime implementation or existing wire format changes.Tracks
morphir-etg2.15.5. The picker-generation cleanup finding is recorded asmorphir-jk7dand included in the lifecycle expectations for adoption.