Repository navigation
Preserve replacement native workspace pickers - #101
Merged
Merged
Conversation
Bind deferred cancellation to its original picker ticket. A stale completion after cancellation must leave a replacement picker and the existing workspace grant intact.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling picker A can let picker B start before A completes. The old handler's deferred cleanup then cancels whichever picker is current, so A's stale completion can invalidate B.
Bind deferred cleanup to its original native ticket. Explicit user cancellation still cancels the current picker. Add real-filesystem acceptance for stale completion after replacement, matching and repeated cleanup, and continued byte-exact access through the existing grant.
Validation: native workspace acceptance, Proton 0.3.4 release host build, full
mise run check: lint/format/validation, all four-target unit suites, CLI/npm/compiler workflows, 60 process-fault cases and all builds. The public native-profile contribution is tracked separately in finos/morphir#1048; this keeps the private implementation safe during adoption.Tracks
morphir-jk7d, discovered duringmorphir-etg2.15.5contract review.