Repository navigation
Define authenticated Workbench job HTTP profile - #1047
Merged
Merged
Conversation
✅ Deploy Preview for angry-raman-7c44f6 canceled.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
DamianReeves
added a commit
to finos/morphir-moonbit
that referenced
this pull request
Oct 15, 2026
Enable opt-in authenticated evaluation through the separate Workbench HTTP job profile. Capture immutable typed JSON/Ion inputs, admit qualified receipts, and schedule isolated Scheme workers with cancellation, confirmed cleanup and explicit terminal release. Preserve connected v1 manifests and RPC methods. Retain the latest host entry draft and full result across navigation. Block model replacement while a pending or disconnected job needs reconciliation, including a lost terminal release response. Qualified on JS/native/Wasm/Wasm GC with full repository checks, 64 Workbench Node tests, and real authenticated Chromium/packaged Proton acceptance with ten submissions each. Standalone Chromium and repackaged Proton also pass. Both verified review findings are fixed and addressed. Refs morphir-etg2.13; paired protocol finos/morphir#1047.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an opt-in authenticated HTTP profile for Workbench submission, query, cancellation and terminal release. It binds the existing receipt draft.1 and terminal draft.5 to a freshly authenticated connected v1 session without changing v1 manifests or JSON-RPC methods.
The closed schemas and profile define immutable submission identity, duplicate-aware bounded framing, JSON/Ion inputs, exact same-session resume, cancellation acknowledgement and explicit retention cleanup. The composing gateway selects its own execution provider; the Rust v1 host remains the authentication authority.
Validation: all historical Workbench schema gates and 71 new host cases pass, including 57 negative cases; repository formatting passes. Paired implementation: finos/morphir-moonbit#87. Real authenticated Chromium and packaged Proton each pass eight evaluation jobs, and jobs-disabled connected v1 plus standalone browser/Proton acceptance pass.
Tracks morphir-etg2.13. Native daemon IPC and durable recovery remain separate work.