Repository navigation
Enable authenticated Workbench evaluation jobs - #87
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90459e4eec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
DamianReeves
added a commit
to finos/morphir
that referenced
this pull request
Oct 15, 2026
Bind existing job receipts and terminal outcomes to per-request connected v1 session authentication. Define closed HTTP submission/query/cancel/release contracts with JSON and Ion inputs, bounded framing, explicit retention and same-session reconciliation. Add 71 independent structural cases to the existing schema gate. Refs morphir-etg2.13; paired implementation finos/morphir-moonbit#87.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected Model Explorer can evaluate public entries through a separately authenticated job offer. Fields, JSON and Ion inputs use one immutable captured model and the existing typed Scheme evaluator. Jobs remain disabled unless
MORPHIR_WORKBENCH_JOBS=1is set alongside the explicit loopback Rust host URL.The gateway authenticates every job request against the real connected v1 session cookie, delegates admission and receipts to shared MoonBit code, and schedules at most two isolated Node workers. Cancellation acknowledgement stays separate from terminal evidence; workers must exit and cleanup must complete before publication. Requests, outputs and retained jobs have explicit bounds, with duplicate-aware framing and an Ion lexical depth check before recursive parsing.
The shared browser/Proton UI retains admitted state across a failed query, explicitly reauthenticates before resuming the same identity, blocks blind retry of unknown submissions, and displays actual terminal evidence in Output/Diagnostics. The latest host entry retains its editable draft and full result across declaration navigation; a disconnected terminal awaiting release reconciliation also blocks model replacement. Packaged Proton accepts an explicit one-use loopback launch URL. Connected v1 manifests and JSON-RPC methods remain unchanged.
Paired protocol contribution merged: finos/morphir#1047 at
d25a180b. Tracksmorphir-etg2.13. Native daemon IPC, generated-code browser execution and durable recovery remain separate follow-ups.Validation:
mise run checkpasses on final head85f57da, including all four target test/build suites, CLI/installed npm, generated compiler acceptance, 60 execution-fault cases and rich execution. Required lint, format and package/configuration validation pass; main test(host): finish signed provider qualification #86 is incorporated.