Repository navigation
fix(opds): cap Argon2 concurrency and bound request pressure - #144
Closed
phildenhoff wants to merge 6 commits into
Closed
phildenhoff wants to merge 6 commits into
phildenhoff wants to merge 6 commits into
Conversation
phildenhoff
added this pull request to stack #145
September 17, 2026 18:59
This was referenced Sep 17, 2026
phildenhoff
changed the title
phildenhoff
force-pushed
the
stack-4-packaging
branch
from
September 17, 2026 19:23
a76576c to
ace7fa5
Compare
libcalibre Test Coverage ReportOverall coverage: 83.86% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 83.86% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
stack-4-packaging
branch
from
September 17, 2026 21:55
ace7fa5 to
ba689a2
Compare
libcalibre Test Coverage ReportOverall coverage: 83.86% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
stack-4-packaging
branch
from
September 17, 2026 21:58
ba689a2 to
9ec3c5e
Compare
libcalibre Test Coverage ReportOverall coverage: 83.86% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 83.86% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 83.86% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
stack-4-packaging
branch
from
September 17, 2026 22:35
9ec3c5e to
53549a2
Compare
libcalibre Test Coverage ReportOverall coverage: 83.86% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 83.86% Coverage breakdown available in the artifacts. |
Merge-blocking hardening from the v1 review: - Limit concurrent password verifications to 3 permits; excess requests get 503 with Retry-After without hashing or caching the header - Bound catalog feeds with a 30s timeout, 16KiB request-body limit, and a shared 64-request permit pool; asset downloads stay untimed - Reject link-local explicit listener addresses in the headless server and assert advertised URLs are IPv4-first without link-local entries - Note in the Sharing pane that generated passwords are shown once and travel unencrypted
phildenhoff
force-pushed
the
stack-4-packaging
branch
from
September 17, 2026 22:50
53549a2 to
a20a4e0
Compare
libcalibre Test Coverage ReportOverall coverage: 83.86% Coverage breakdown available in the artifacts. |
libcalibre Test Coverage ReportOverall coverage: 83.86% Coverage breakdown available in the artifacts. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-merge review distilled the v1 blockers down to "cap the expensive path, cap the inputs, don't leak the secret." This does that:
fe80::entries(One known gap, deliberately deferred: the request guard only engages after headers arrive, so slowloris-style connections aren't bounded yet. Follow-up material.)
Validation
62 crate tests, including new ones for the busy-verifier 503 path, guard exhaustion, feed-timeout vs. untimed assets, format traversal attempts (
..%2fetc. → 400), and link-local config rejection.cargo check -p citadel-rsand the frontend suite (216 tests) stay green.Also lands the packaged-side validation evidence: the signed/notarized nightly smoke test and Linux package checks recorded in
docs/opds-validation.md.