Repository navigation
chore(toolchain): install the pinned Rust toolchain in CI - #141
Merged
Merged
Conversation
phildenhoff
added this pull request to stack #145
September 17, 2026 18:59
libcalibre Test Coverage ReportOverall coverage: 81.75% Coverage breakdown available in the artifacts. |
phildenhoff
changed the title
phildenhoff
force-pushed
the
stack-1-toolchain
branch
from
September 17, 2026 19:23
91746aa to
9abee3c
Compare
libcalibre Test Coverage ReportOverall coverage: 81.75% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
stack-1-toolchain
branch
from
September 17, 2026 21:54
9abee3c to
057d121
Compare
libcalibre Test Coverage ReportOverall coverage: 81.75% Coverage breakdown available in the artifacts. |
phildenhoff
force-pushed
the
stack-1-toolchain
branch
from
September 17, 2026 21:58
057d121 to
e45d368
Compare
libcalibre Test Coverage ReportOverall coverage: 81.75% Coverage breakdown available in the artifacts. |
phildenhoff
marked this pull request as ready for review
September 17, 2026 22:34
CI hardcoded its Rust version in four workflows while rust-toolchain.toml already pins it. Install with bare `rustup toolchain install` so the file stays the single source of truth for channel, profile, and components; README points at the pin instead of naming a version.
phildenhoff
force-pushed
the
stack-1-toolchain
branch
from
September 17, 2026 22:35
e45d368 to
a4b0c50
Compare
phildenhoff
changed the title
libcalibre Test Coverage ReportOverall coverage: 81.75% Coverage breakdown available in the artifacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI hardcoded the Rust version in four workflows while
rust-toolchain.tomlalready pins it — two sources of truth for one fact. This makes the file the only source: CI runsrustup toolchain install, which reads channel, profile, and the clippy/rustfmt components straight fromrust-toolchain.toml, so bumping the pin is a one-file change.README now points at the pin instead of naming a version, and asks for
rustup toolchain installonce after cloning (rather than promising auto-install on first cargo command — rustup 1.28 deprecation footgun).Stack
This is the bottom layer of the OPDS v1 stack (#142 → #143 → #144 → #137). Mergeable on its own.