Repository navigation
fix(uniforms): convert uniform values and numeric sequences with ToNumber - #27
Merged
dsafdsaf132 merged 1 commit intoOct 26, 2026
Merged
Conversation
…mber uniform1i(loc, true) threw "Argument is not a number!" and uniform2iv(loc, [true, false]) threw "A number was expected", where browsers convert both, as WebIDL requires. three.js passes booleans for its bool uniforms, so every lit material failed. GetUniformValueParam and the plain-array branch of GetArrayLikeBuffer now convert a non-number with napi_coerce_to_number. null and undefined keep their existing handling, typed arrays are untouched, and a Symbol still throws TypeError. The array branch also serves bufferData, vertexAttrib*v and the other setters that take a sequence, which browsers convert the same way. webgl2-smoke gains testUniformValueConversion, which fails on the old code and passes on this one. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uniform1i(loc, true) threw "Argument is not a number!" and uniform2iv(loc, [true, false]) threw "A number was expected", where browsers convert both, as WebIDL requires. three.js passes booleans for its bool uniforms, so every lit material failed.
GetUniformValueParam and the plain-array branch of GetArrayLikeBuffer now convert a non-number with napi_coerce_to_number. null and undefined keep their existing handling, typed arrays are untouched, and a Symbol still throws TypeError. The array branch also serves bufferData, vertexAttrib*v and the other setters that take a sequence, which browsers convert the same way.
webgl2-smoke gains testUniformValueConversion, which fails on the old code and passes on this one.