Skip to content

fix: keep the desktop capture frame rate at the configured value #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devopvoid merged 1 commit into from
Sep 7, 2026
Merged

fix: keep the desktop capture frame rate at the configured value #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions webrtc-jni/src/main/cpp/src/media/video/VideoTrackDesktopSource.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include "third_party/libyuv/include/libyuv/video_common.h"
#include "rtc_base/logging.h"
#include "rtc_base/thread.h"
#include "rtc_base/time_utils.h"

#include "modules/desktop_capture/desktop_capturer.h"
#include "modules/desktop_capture/desktop_and_cursor_composer.h"
Expand Down Expand Up @@ -301,15 +302,24 @@ namespace jni

sourceState = kLive;

int msPerFrame = 1000 / frameRate;
const int64_t msPerFrame = 1000 / frameRate;

while (isCapturing) {
const int64_t frameStart = webrtc::TimeMillis();

#if defined(WEBRTC_MAC)
CFRunLoopRunInMode(kCFRunLoopDefaultMode, 0, true);
#endif
capturer->CaptureFrame();

webrtc::Thread::SleepMs(msPerFrame);
// CaptureFrame takes time of its own, up to a full display refresh
// with DXGI, so sleeping the whole interval afterwards halved the
// effective frame rate. Sleep only for what is left of the interval.
const int64_t elapsed = webrtc::TimeMillis() - frameStart;

if (elapsed < msPerFrame) {
webrtc::Thread::SleepMs(static_cast<int>(msPerFrame - elapsed));
}
}

capturer.reset();
Expand Down
Loading