fix: keep the desktop capture frame rate at the configured value - #274
Merged
devopvoid merged 1 commit intoSep 7, 2026
Merged
Conversation
The capture loop slept for a full frame interval after every CaptureFrame call, ignoring the time the capture itself took. With DXGI a capture can take a whole display refresh, so a source configured for 60 frames per second produced 30, and higher settings changed nothing. The loop now measures the capture and sleeps only for the remainder of the interval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop capture loop slept for a full frame interval after every
CaptureFramecall, ignoring the time the capture itself took. With DXGI a capture can take a whole display refresh, so a source configured for 60 frames per second produced 30, which is the 32 ms cadence measured in #157, and higher settings changed nothing. The loop now measures the capture and sleeps only for the remainder of the interval. The CI runners have no display, so this is verified by the timing arithmetic, which matches the reported measurement exactly, rather than by a frame rate measurement.Fixes #157