Repository navigation
release: declare the MSVC PDB at every strip level, evidence cquery takes one union (part of #8410) - #8471
Merged
Conversation
…akes one union (part of #8410) rules_rust only declared the rustc .pdb when strip_level was none, so the opt dx_pdb target was empty. rustc writes the PDB on MSVC whatever the strip level (rust-lang/rust#115120), so msvc_pdb_output.patch declares it for every MSVC bin and cdylib. evidence.yml joins the scope with + so the determinism cquery gets one expression. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8410
.github/workflows/evidence.yml: the determinism cquery gets the scope as one union (${DX_SCOPE// / + }). Safe becausetools/ci/evidence_inputs.rsjoins patterns with single spaces and only allows//or@rules_dx_patterns. This fixes the failure after the build in run 42207809929.patches/rules_rust/msvc_pdb_output.patch: rules_rust only declared the rustc.pdbwhenstrip_level == "none", so opt//cli/cli:dx_pdbwas empty. rustc writes the PDB on MSVC at every strip level (Ignore-C stripon MSVC rust-lang/rust#115120, Match the behavior ofstripandsplit-debuginfoacross platforms rust-lang/compiler-team#669), so the patch declares it for every MSVCbin/cdylib. rustc's arguments do not change. Wired inMODULE.bazel,patches/rules_rust/BUILD.bazel,patches/README.md,cli/adopt(BUILD,overrides.rsplus its render test) andfamilies/{android,apple,beam,dotnet,jvm}/third_party/rules_dx.rust/rules/defs.bzl: the comment now says the PDB is declared through the patch.Tests (local, linux):
//tools/ci:actionlint_test,//tools/ci:evidence_inputs_test,//tools/ci:workflow_expressions_test,//rust/tests/fixtures/hello:wrapper_registry_tests,//patches/llvm:libunwind_copy_test.//cli/adopt:dx_adopt_test: the rules_rust override drift and render checks pass. Two checks still fail, and both fail on main too:table_matches_the_repo_module_bazel("MODULE.bazel overrides lua; add it to OVERRIDES") andpreflight::deps_match_the_repo_module_bazel.//tools/ci:input_validation_testevidence_runners_match_the_tablefails on main too, because evidence.yml has noPLATFORMSdict.*_consumer_testtargets were not run.Windows evidence: run 42216510920 (
task=build,relocate=true,--config=dx_release, windows_x86_64 + windows_arm64, scope//cli/cli:dx //cli/cli:dx_pdb //deploy/release:dx_host_cell). It was still running when this PR was opened. I'll add thedeterminism.txtdigests fordx.exeanddx.pdbwhen it finishes.Remaining for #8410: confirm
matchfordx.exeanddx.pdbon both cells in run 42216510920.🤖 Generated with Claude Code
https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK