Repository navigation
release: ship dx-windows-*-pdb.zip debug symbols with each Windows cell (part of #8428) - #8467
Merged
Merged
Conversation
TrapsterDK
marked this pull request as draft
November 6, 2026 12:10
TrapsterDK
force-pushed
the
fix-8428-pdb-zip
branch
from
November 6, 2026 12:56
716b782 to
4171e68
Compare
This was referenced Nov 6, 2026
…ll (closes #8428) Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
… (part of #8428) Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
…#8428) /pdbaltpath:%_PDB% writes dx_upstream.pdb into dx.exe, so a renamed dx.pdb would not be found next to the exe. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
TrapsterDK
force-pushed
the
fix-8428-pdb-zip
branch
from
November 6, 2026 14:21
ea4bb8b to
7b4e60c
Compare
Collaborator
Author
|
Handoff: evidence run 42232865025 (windows_x86_64, windows_arm64, When the run finishes:
In every case, delete the throwaway branch afterwards ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8428
Rebased onto main (after #8459 and #8471). #8471's
msvc_pdb_output.patchalready declares the MSVC PDB at every strip level, so nostrip_levelchange is needed.Changes
deploy/release/matrix.bzl: each Windows cell gets<cell>_pdb_archive(dx-windows-<cpu>-pdb.zip, via the Bazel zipper), a.sha256and an SPDX SBOM.:dx_host_cell_pdband:dx_host_cell_pdb_sbomalias the host cell.release_cell_symbolsnames the file; the matrix JSON is unchanged.dx_upstream.pdb, notdx.pdb:/pdbaltpath:%_PDB%writes the PDB basename of the upstreamrust_binaryintodx.exe, so a renamed PDB would not be found next to the exe.deploy/release/src/cell.rs:qualifytakes optional--symbolsand--symbols-rebuild; thedeterminismcheck also compares their digests.tools/ci/release_cell.sh: builds, copies and rebuilds the symbols zip on Windows cells and passes it toqualify..github/workflows/release.yml: the symbols zip, its.sha256and SPDX go into the checksum manifest (15 -> 19 lines),files.listand the attestation verification loop.cli/adopt/src/launcher.rs: the pin parser skips the symbols zip and its SBOM lines (Windows only).matrix_unit,qualify_compares_the_symbols_rebuild, launcher parser test,release_assets_teststrings,windows_host_cell_ships_its_symbols_zipinrelease_host_cell_test, and the new//cli/cli:dx_opt_pdb_test(dx_msvc_opt_pdb_testsinrust/rules/wrapper_tests.bzl, Windows only,compilation_mode=opt, checks thepdb_fileoutput group is exactlydx_upstream.pdb).Local (linux):
matrix_unit,dx_release_tools_clippy_test, the//rust/rules/...analysis tests anddx_adopt_clippy_testpass. These fail on main too: rustfmt aspect targets (dx_release_tools_fmt_test,bench_report_fmt_test,dx_adopt_fmt_test),bcr_templates_test,bump_version_bin_test,candidate_identity_test,release_assets_test(python in ci.yml; launcher shell pattern), anddx_adopt_test(table_matches_the_repo_module_bazel,deps_match_the_repo_module_bazel). Nested-Bazel and*_consumer_testtargets were not run.Evidence (windows_x86_64, windows_arm64)
task=build relocate=true,--config=dx_release,//deploy/release:dx_host_cell //deploy/release:dx_host_cell_pdb): both cells build the exe zip and the pdb zip. The relocated rebuild differs for both, becausedx.exeanddx_upstream.pdbthemselves still differ after relocation. That is release: reproducible PDB for Windows dx.exe so debug symbols can ship #8410 (same result in its run 42216510920).task=test):dx_opt_pdb_testreporteddx_upstream.pdb(fixed in the last commit by expecting that name).host_cell_ships_exactly_its_membersfails because the archive lists the CRT DLLs while the cell runtime listsmsvc_vcruntime/windows_ucrt. That test is not changed here.Evidence (stacked on #8568)
'${pwd}' syntax is not supportedin acargo_build_script), caused by release: relative paths in MSVC opt links so the PDB is reproducible (part of #8410) #8568's first commit; release: relative paths in MSVC opt links so the PDB is reproducible (part of #8410) #8568 fixed it in 82d5dff. Rerun as 42235987911 onevidence-8428-on-8568(ee232e1, now including 82d5dff), same inputs:task=build relocate=true,--config=dx_release,//deploy/release:dx_host_cell //deploy/release:dx_host_cell_pdb, windows_x86_64 and windows_arm64) on the throwaway branchevidence-8428-on-8568: this PR merged into release: relative paths in MSVC opt links so the PDB is reproducible (part of #8410) #8568's branch (fix-8410-msvc-paths), no conflicts. Both cells build the exe zip and the pdb zip, so both the exe zip and the pdb zip rebuild identically once release: relative paths in MSVC opt links so the PDB is reproducible (part of #8410) #8568 lands. It proves this PR only together with release: relative paths in MSVC opt links so the PDB is reproducible (part of #8410) #8568 as it is now; if release: relative paths in MSVC opt links so the PDB is reproducible (part of #8410) #8568 changes before merging, rerun it.Rebased onto main again (f09c42f). Local (linux):
matrix_unit,dx_release_tools_clippy_test,dx_adopt_clippy_testand the//rust/tests/fixtures/helloanalysis tests (thin_rust_test,wrapper_conformance_tests,wrapper_registry_tests,wrapper_registry_tests_forward) pass.dx_opt_pdb_testis Windows only. Nested-Bazel and*_consumer_testtargets were not run.The
host_cell_ships_exactly_its_membersfailure is tracked in #8571.Remaining (blocks closing #8428)
🤖 Generated with Claude Code
https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK