Skip to content

test: fork PR held at integration-success (do not merge) - #129

Closed
mislavivanda wants to merge 2 commits into
daytona:mainfrom
mislavivanda:test/fork-lane-hold
Closed

mislavivanda wants to merge 2 commits into
daytona:mainfrom
mislavivanda:test/fork-lane-hold

Conversation

@mislavivanda

@mislavivanda mislavivanda commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Temporary fork PR to test #128. It will be closed after the test.


Summary by cubic

Removes the pull_request_target lane from the integration workflow so fork PRs never run under DAYTONA_API_KEY. The previous approval gate bound to whichever run was waiting, not the commit being reviewed, so a contributor could get an older commit approved than the one shown in "Files changed".

Fork PRs that touch a live-tested package now keep integration-success at "Expected" instead of passing via the other lane's skipped roll-up. A maintainer runs the suites on the reviewed commit from a repo branch (instructions added to CONTRIBUTING.md); the fork-lane concurrency policy can be deleted after merge. This PR is itself the fork-lane test for #128 and is not for merge.

Written for commit 049262d. Summary will update on new commits.

View guided diff

The fork lane checked out a fork PR's head and ran its install and test
code with DAYTONA_API_KEY, gated only by the integration-tests approval.
That approval binds to whichever run is waiting, and each run is pinned
to the commit that was the PR head when it started, so a contributor can
get an older commit approved than the one shown in "Files changed".

Run the suites only on pull_request from branches in this repo. Fork PRs
never get the key, so a fork PR that touches a live-tested package now
reports integration-success under another name, and the required check
stays "Expected" until a maintainer pushes the reviewed commit to a
branch here and runs the workflow on it (see CONTRIBUTING.md).

This also removes the other lane's skipped integration-success, which
GitHub counted as passing, so in-repo PRs no longer pass the gate before
their live suites ran. Policy 14618 can be deleted once this is merged.

Signed-off-by: Mislav Ivanda <[email protected]>
@mislavivanda

Copy link
Copy Markdown
Collaborator Author

Test PR for #128, done; closing. The branch is deleted.

This branch had an error being deployed

1 failed deployment
integration-tests — 049262d2 Deployed Nov 19, 2026 by mislavivanda via pi #332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant