Repository navigation
test: fork PR held at integration-success (do not merge) - #129
Closed
mislavivanda wants to merge 2 commits into
Closed
mislavivanda wants to merge 2 commits into
mislavivanda wants to merge 2 commits into
Conversation
The fork lane checked out a fork PR's head and ran its install and test code with DAYTONA_API_KEY, gated only by the integration-tests approval. That approval binds to whichever run is waiting, and each run is pinned to the commit that was the PR head when it started, so a contributor can get an older commit approved than the one shown in "Files changed". Run the suites only on pull_request from branches in this repo. Fork PRs never get the key, so a fork PR that touches a live-tested package now reports integration-success under another name, and the required check stays "Expected" until a maintainer pushes the reviewed commit to a branch here and runs the workflow on it (see CONTRIBUTING.md). This also removes the other lane's skipped integration-success, which GitHub counted as passing, so in-repo PRs no longer pass the gate before their live suites ran. Policy 14618 can be deleted once this is merged. Signed-off-by: Mislav Ivanda <[email protected]>
Signed-off-by: Mislav Ivanda <[email protected]>
mislavivanda
had a problem deploying
to
integration-tests
November 19, 2026 12:37 — with
GitHub Actions
Error
mislavivanda
had a problem deploying
to
integration-tests
November 19, 2026 12:37 — with
GitHub Actions
Failure
Collaborator
Author
|
Test PR for #128, done; closing. The branch is deleted. |
6 tasks done
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary fork PR to test #128. It will be closed after the test.
Summary by cubic
Removes the
pull_request_targetlane from the integration workflow so fork PRs never run underDAYTONA_API_KEY. The previous approval gate bound to whichever run was waiting, not the commit being reviewed, so a contributor could get an older commit approved than the one shown in "Files changed".Fork PRs that touch a live-tested package now keep
integration-successat "Expected" instead of passing via the other lane's skipped roll-up. A maintainer runs the suites on the reviewed commit from a repo branch (instructions added toCONTRIBUTING.md); the fork-lane concurrency policy can be deleted after merge. This PR is itself the fork-lane test for #128 and is not for merge.Written for commit 049262d. Summary will update on new commits.