Repository navigation
ci: drop the pull_request_target lane from the integration tests - #128
Merged
Merged
Conversation
The fork lane checked out a fork PR's head and ran its install and test code with DAYTONA_API_KEY, gated only by the integration-tests approval. That approval binds to whichever run is waiting, and each run is pinned to the commit that was the PR head when it started, so a contributor can get an older commit approved than the one shown in "Files changed". Run the suites only on pull_request from branches in this repo. Fork PRs never get the key, so a fork PR that touches a live-tested package now reports integration-success under another name and the required check stays "Expected". Maintainers review it, push the reviewed commit to a branch here and merge a PR from that branch instead (CONTRIBUTING.md): checks from runs on other branches don't count for the fork PR, even on the same commit. This also removes the other lane's skipped integration-success, which GitHub counted as passing, so in-repo PRs no longer pass the gate before their live suites ran. Policy 14618 can be deleted once this is merged. Signed-off-by: Mislav Ivanda <[email protected]>
mislavivanda
force-pushed
the
ci/drop-fork-integration-lane
branch
from
November 19, 2026 12:41
366199f to
7403760
Compare
mislavivanda
marked this pull request as ready for review
November 19, 2026 12:42
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Contributors only need to know why integration-success stays pending on their PR and that a maintainer runs the live tests on a copy of it; the maintainer runbook doesn't belong in a contributor-facing document. Signed-off-by: Mislav Ivanda <[email protected]>
A fork PR that touches a live-tested package is merged through a copy from a branch in this repo, so the contributor's own PR gets closed. Say up front that the merged commit credits them as co-author. Signed-off-by: Mislav Ivanda <[email protected]>
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
View guided diff | Turn on auto-fix | Re-trigger cubic
The paragraph's opening condition covered every PR that changes a live-tested package, but only fork PRs go through a maintainer's copy; PRs from branches in this repo run their live tests on the PR itself. Signed-off-by: Mislav Ivanda <[email protected]>
aprojic
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
pull_request_targetlane fromintegration.yml, ahead of GitHub's Dec 2 change. Once this is merged, Actions policy 14618 (which allowspull_request_targetforintegration.yml) can be deleted.Why
DAYTONA_API_KEY, gated only by theintegration-testsapproval. That approval binds to whichever run is waiting, and each run is pinned to the commit that was the PR head when it started. A run waiting for approval keeps its place in the queue; feat(agentenv-daytona)!: migrate to Daytona SDK 2.x (v0 namespace) #111's run sat behind a Nov 16 run on a commit that was no longer on the branch. So a contributor could push a malicious commit and then a clean one: "Files changed" shows the clean one, while the waiting run checks out the malicious one.integration-success, which GitHub counts as passing. feat(agentenv-daytona)!: migrate to Daytona SDK 2.x (v0 namespace) #111 showed as mergeable on Nov 17 while its live run was still queued. With one lane, in-repo PRs wait for the real result.What changes
on:no longer includespull_request_target. The suites check out the default ref again (noref:, noallow-unsafe-pr-checkout);persist-credentials: falsestays.decide()runs suites only for PRs from branches in this repo, and for dispatch. For a fork PR that touches a live-tested package, it setsneeds_maintainer_run.integration-successnever skips. Withneeds_maintainer_run, it reports asintegration-success (fork PR, needs a maintainer run), so the required check stays "Expected" and the fork PR can't merge untested. Fork PRs that don't touch a live-tested package pass as before.integration-successstays pending on their PR, that a maintainer runs the live tests on a copy of it and merges that copy, and that the merged commit credits them as co-author.Testing
actionlintpasses. I extracted thedecidestep and ran it locally for six cases: in-repo PRs and fork PRs, each with and without a package change, plus dispatch withpiand withall. It routes all six correctly.mislavivanda/integrations, built on this branch plus a change inpackages/pi-extension. Itsintegrationrun (44525506813) ran no suites and reportedintegration-success (fork PR, needs a maintainer run). The commit had no check namedintegration-success, so the required check stayed "Expected" (rollup PENDING).integration-successwas attached to the commit, but it didn't count for test: fork PR held at integration-success (do not merge) #129: it's not in test: fork PR held at integration-success (do not merge) #129's rollup, and its check suite isn't linked to the PR. So a maintainer run can't make the fork PR itself mergeable, and the maintainer merges an in-repo copy instead.main'spull_request_targetlane still posts a skippedintegration-successon every PR. After merge, an in-repo PR that touches a package should showintegration-successas "Expected" until its live run is approved and passes.#129, its branches, and
main's old fork-lane run on it are cleaned up. That run was cancelled without approval.Related issue(s)
None.
Scope
(e.g.
feat(pi-extension): ...,fix(adk-plugin): ...) — it becomes the squash-commitmessage that release-please reads.
Checks
actionlintpasses, plus the tests above.)Legal
DCO (
git commit -s); the sign-off matches thecommit author.
Contributor License Agreement.
On my first PR, the CLA assistant will comment and I will reply to sign (once).
See CONTRIBUTING.md for
details.