Skip to content

chore(tests): delete duplicate and unwired test harnesses #6491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daggerstuff merged 1 commit into from
Nov 3, 2026
Merged

chore(tests): delete duplicate and unwired test harnesses #6491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ Thumbs.db

# Test files and coverage
tests/
!tests/integration/package.json
coverage/
.nyc_output/
test-results/
Expand Down
1 change: 0 additions & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ packages:
- 'apps/business-strategy-cms'
- 'agents/*'
- 'packages/*'
- 'tests/integration'
- 'foresight/cli'
- 'tools/px'
# Committed lockfile is the trusted source of truth;
Comment on lines 3 to 8

@sentry sentry Bot Nov 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The foresight/cli importer was removed from pnpm-lock.yaml while remaining in pnpm-workspace.yaml, causing frozen lockfile installations to fail when the submodule is checked out.
Severity: MEDIUM

Suggested Fix

Regenerate pnpm-lock.yaml with the foresight submodule checked out so the foresight/cli importer is retained, or remove foresight/cli from pnpm-workspace.yaml if it is intentionally no longer a workspace package.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: pnpm-workspace.yaml#L3-L8

Potential issue: `pnpm-workspace.yaml` retains `foresight/cli` as a workspace package,
but the regenerated `pnpm-lock.yaml` removed the corresponding `foresight/cli` importer.
When submodules are initialized (such as during CI in `ci.yml` before building
`infra/docker/Dockerfile.production`), `foresight/cli` is present in the build context.
Running `pnpm install --frozen-lockfile` will fail with `ERR_PNPM_OUTDATED_LOCKFILE` due
to the discrepancy between the workspace declaration and the lockfile.

Did we get this right? 👍 / 👎 to inform future reviews.

Expand Down
42 changes: 0 additions & 42 deletions tests/browser-compatibility.spec.ts
View file
Open in desktop

This file was deleted.

Loading
Loading