Repository navigation
chore(tests): delete duplicate and unwired test harnesses - #6491
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis cleanup removes 12 duplicate, orphaned, or unwired test-harness files and updates workspace metadata and E2E documentation to reflect the supported test entrypoints. Canonical browser/mobile tests and CI coverage remain unchanged; lint and build pass, while Vitest reports the same pre-existing failures as baseline and Playwright successfully discovers 949 tests across 9 browser files. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
github-actions
Bot
added
the
documentation
px Advisor ReviewRisk: unknown No summary available No findings. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
3
to
8
| - 'apps/business-strategy-cms' | ||
| - 'agents/*' | ||
| - 'packages/*' | ||
| - 'tests/integration' | ||
| - 'foresight/cli' | ||
| - 'tools/px' | ||
| # Committed lockfile is the trusted source of truth; |
Contributor
There was a problem hiding this comment.
Bug: The foresight/cli importer was removed from pnpm-lock.yaml while remaining in pnpm-workspace.yaml, causing frozen lockfile installations to fail when the submodule is checked out.
Severity: MEDIUM
Suggested Fix
Regenerate pnpm-lock.yaml with the foresight submodule checked out so the foresight/cli importer is retained, or remove foresight/cli from pnpm-workspace.yaml if it is intentionally no longer a workspace package.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: pnpm-workspace.yaml#L3-L8
Potential issue: `pnpm-workspace.yaml` retains `foresight/cli` as a workspace package,
but the regenerated `pnpm-lock.yaml` removed the corresponding `foresight/cli` importer.
When submodules are initialized (such as during CI in `ci.yml` before building
`infra/docker/Dockerfile.production`), `foresight/cli` is present in the build context.
Running `pnpm install --frozen-lockfile` will fail with `ERR_PNPM_OUTDATED_LOCKFILE` due
to the discrepancy between the workspace declaration and the lockfile.
Did we get this right? 👍 / 👎 to inform future reviews.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Lighthouse CI ResultsRoutes audited: Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85 Reports
|
daggerstuff
force-pushed
the
cursor/delete-duplicate-test-harnesses-e5bf
branch
from
November 3, 2026 14:06
ec3ae3a to
6b75567
Compare
px Advisor ReviewRisk: unknown No summary available No findings. |
Lighthouse CI ResultsRoutes audited: Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85 Reports
|
daggerstuff
force-pushed
the
cursor/delete-duplicate-test-harnesses-e5bf
branch
from
November 3, 2026 14:27
6b75567 to
6138e6c
Compare
px Advisor ReviewRisk: unknown No summary available No findings. |
Remove root and cross-browser Playwright duplicates, an unwired mobile spec, legacy integration workspace runner, and orphaned config/probe files. Drop the tests/integration pnpm workspace entry and dockerignore exception; point e2e README at config/playwright.config.ts.
daggerstuff
force-pushed
the
cursor/delete-duplicate-test-harnesses-e5bf
branch
from
November 3, 2026 14:52
6138e6c to
0232193
Compare
px Advisor ReviewRisk: unknown No summary available No findings. |
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed (grouped)
Duplicate / unwired Playwright specs
tests/browser-compatibility.spec.ts— overlappedtests/browser/browser-compatibility.spec.ts(validated bybrowser-tests.yml).tests/cross-browser/browser-compatibility.spec.ts— same coverage astests/browser/{browser-compatibility,cross-browser-compatibility}.spec.ts; no workflow references.tests/e2e/mobile-responsiveness.spec.ts— duplicate oftests/mobile/mobile-responsiveness.spec.ts; neither path is referenced by scripts/workflows (kept thetests/mobile/copy as the canonical file).Orphan configs / probes
tests/e2e-config.ts,tests/mcp-e2e-config.ts— only self/README references; nopackage.jsonscripts (MCP script was already absent).tests/home-hero-layout.mjs— no repo references.Legacy integration harness
tests/integration/package.json,tests/integration/integration-test-runner.ts— unwired; root usespnpm test:integration→vitest run tests/integration/.tests/integrationfrompnpm-workspace.yamland lockfile; dropped.dockerignore!tests/integration/package.jsonexception.Docs
tests/e2e/README.md— points atconfig/playwright.config.tsinstead of deleted mini-configs; removed stale MCP section.Intentionally untouched
tests/accessibility/**(owner decision).package.json(including stalee2e:browser-compatpath — handled in open PR chore: remove broken root scripts and dead config #6490).Kept / not ported
No assertion porting: deleted browser specs were strict subsets of
tests/browser/*. CI entrypoints remaintests/browser/auth.spec.tsandtests/browser/browser-compatibility.spec.ts.Proof
pnpm lintpnpm buildpnpm vitest run -c config/vitest.config.tspnpm exec playwright test --list -c config/playwright.config.ts*.test.tsfiles undertests/still emit loader errors;tests/browserlists 949 tests in 9 files).Failed vitest files (both baseline and branch):
auth.test.ts,useChatCompletion.test.ts,chain.test.ts,logger.test.ts,db-ssl-config.test.ts,ehr-rbac.test.ts,compliance-validator.test.ts,fhe-integration.test.ts,graphql.test.ts,skills-api.test.ts.Net change
−1,891 lines (12 files, +5 / −1,896 per
git diff --shortstat staging).Summary by Sourcery
Clean up obsolete test harnesses and consolidate testing around the repository's active configurations and canonical specs.
Enhancements:
Build:
Documentation:
Chores: