Skip to content

chore: remove unwired markdown and vite plugin trees - #6466

Merged
daggerstuff merged 1 commit into
stagingfrom
cursor/remove-dead-markdown-plugins-28eb
Nov 3, 2026
Merged

daggerstuff merged 1 commit into
stagingfrom
cursor/remove-dead-markdown-plugins-28eb

Conversation

@daggerstuff

@daggerstuff daggerstuff commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Nightly audit area 6. Subtraction only: +1/-1067 across 18 files.

What

  • Delete repo-root plugins/ (index.ts, remark-reading-time.ts, remark-generate-og-image.ts, og-template/*).
  • Delete apps/web/src/plugins/** (remark copies, 5 vite-plugin stubs, index.ts).
  • Drop ./plugins/**/*.ts from tsconfig.json and config/tsconfig.json; drop stale JSDoc pointer in apps/web/src/types.ts.

Why it is dead

  • astro.config.mjs and infra/docker/astro.config.mjs configure markdown with shikiConfig only; no remarkPlugins/rehypePlugins.
  • Nothing imports plugins/index.ts or any file under apps/web/src/plugins/. Reading time comes from frontmatter (schema.ts) and utils/blog.ts.
  • OG images come from Head.astro/config; the og-template font was already missing.

Kept: ListView.astro remarkPluginFrontmatter fallback, historical changelog bullets.

Proof

  • pnpm lint: pass
  • pnpm build: pass
  • vitest -c config/vitest.config.ts: no failures touch deleted paths (graphql-yoga import failure is pre-existing on staging).

Summary by Sourcery

Enhancements:

  • Remove unused repository-root and web markdown/Vite plugin trees and their stale TypeScript inclusions and documentation references.

@vercel

vercel Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pixelated Ready Ready Preview Nov 3, 2026 3:20pm UTC

Request Review

@sourcery-ai

sourcery-ai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This subtraction-only change removes unwired repository and web Markdown/Vite plugin trees, including obsolete OG-image helpers, while cleaning TypeScript inclusion paths and stale documentation; active Astro configuration, frontmatter-based reading time, OG image generation, and retained fallback behavior are left intact. Reviewers should verify that no runtime imports or configuration references depend on the deleted files and that the reported lint, build, and test validation covers the removal.

File-Level Changes

Change Details Files
Remove unused Markdown/remark and Vite plugin implementations from both the repository root and web application.
  • Delete root remark plugins, OG-image template helpers, and plugin index.
  • Delete web-local remark copies, Vite plugin stubs, and plugin index.
  • Retain the active Astro markdown configuration and existing frontmatter-based behavior.
plugins/index.ts
plugins/og-template/base64.ts
plugins/og-template/markup.ts
plugins/remark-generate-og-image.ts
plugins/remark-reading-time.ts
apps/web/src/plugins/index.ts
apps/web/src/plugins/remark-directive-sugar.ts
apps/web/src/plugins/remark-generate-og-image.ts
apps/web/src/plugins/remark-image-container.ts
apps/web/src/plugins/remark-reading-time.ts
apps/web/src/plugins/vite-plugin-external-node.js
apps/web/src/plugins/vite-plugin-middleware-patch.js
apps/web/src/plugins/vite-plugin-node-exclude.js
apps/web/src/plugins/vite-plugin-node-polyfill.js
apps/web/src/plugins/vite-plugin-rewrite-logger-import.js
Clean up configuration and documentation references to the deleted plugin tree.
  • Remove deleted plugin paths from both TypeScript project file lists.
  • Update the UI type JSDoc to remove the stale plugin reference.
tsconfig.json
config/tsconfig.json
apps/web/src/types.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

px Advisor Review

Risk: unknown

No summary available

No findings.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Lighthouse CI Results

Routes audited: /, /dashboard?perf=1, /training-session

Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85

Reports

  • lhr-1793610433763
  • lhr-1793610445591
  • lhr-1793610457007
  • lhr-1793610467919
  • lhr-1793610478675
  • lhr-1793610489477
  • lhr-1793610500452
  • lhr-1793610511288
  • lhr-1793610522263

Reports are also available as workflow artifacts

@daggerstuff
daggerstuff force-pushed the cursor/remove-dead-markdown-plugins-28eb branch from ea5484c to 28c32eb Compare November 2, 2026 12:43
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

px Advisor Review

Risk: unknown

No summary available

No findings.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Lighthouse CI Results

Routes audited: /, /dashboard?perf=1, /training-session

Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85

Reports

  • lhr-1793623699010
  • lhr-1793623711859
  • lhr-1793623724048
  • lhr-1793623735484
  • lhr-1793623746858
  • lhr-1793623758246
  • lhr-1793623769587
  • lhr-1793623780926
  • lhr-1793623792272

Reports are also available as workflow artifacts

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

px Advisor Review

Risk: unknown

No summary available

No findings.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Lighthouse CI Results

Routes audited: /, /dashboard?perf=1, /training-session

Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85

Reports

  • lhr-1793718612529
  • lhr-1793718625280
  • lhr-1793718637528
  • lhr-1793718649046
  • lhr-1793718660418
  • lhr-1793718671829
  • lhr-1793718683182
  • lhr-1793718694571
  • lhr-1793718705904

Reports are also available as workflow artifacts

Delete duplicate remark/rehype plugin copies under apps/web/src/plugins
and repo-root plugins/ that are not imported from astro.config.mjs or
any runtime entrypoint. Markdown processing remains shiki-only per
astro.config.mjs.

Also drop stale tsconfig includes and fix the externalLink JSDoc in
types.ts.
@daggerstuff
daggerstuff force-pushed the cursor/remove-dead-markdown-plugins-28eb branch from de6df77 to 3890f49 Compare November 3, 2026 15:16
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

px Advisor Review

Risk: unknown

No summary available

No findings.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Lighthouse CI Results

Routes audited: /, /dashboard?perf=1, /training-session

Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85

Reports

  • lhr-1793719247872
  • lhr-1793719260587
  • lhr-1793719272645
  • lhr-1793719284034
  • lhr-1793719295276
  • lhr-1793719306560
  • lhr-1793719317823
  • lhr-1793719329041
  • lhr-1793719340311

Reports are also available as workflow artifacts

@daggerstuff
daggerstuff merged commit fa956b8 into staging Nov 3, 2026
40 of 43 checks passed
@daggerstuff
daggerstuff deleted the cursor/remove-dead-markdown-plugins-28eb branch November 3, 2026 15:24
@linear-code

linear-code Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

PIX-4837

This branch was successfully deployed

1 active deployment
Preview — 3890f49d Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants