Repository navigation
chore(web): delete unwired memory api copy and orphan scaffold - #6485
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis subtraction-only cleanup removes verified-unwired duplicate APIs, legacy UI components, demo chains, superseded shims, and committed test artifacts from File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
px Advisor ReviewRisk: unknown No summary available No findings. |
Lighthouse CI ResultsRoutes audited: Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85 Reports
|
7d54a2a to
aeeac0e
Compare
Remove duplicate src/api/memory tree, legacy auth/blog/todo/nav demos, committed Playwright artifacts, and related CI baselines. Live routes remain under src/pages/api/memory and mizu/Navbar.
aeeac0e to
7e6262e
Compare
Lighthouse CI ResultsRoutes audited: Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85 Reports
|
px Advisor ReviewRisk: unknown No summary available No findings. |
1 similar comment
px Advisor ReviewRisk: unknown No summary available No findings. |
Lighthouse CI ResultsRoutes audited: Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85 Reports
|
Summary
Nightly audit area 2 — subtraction-only cleanup in
apps/web: remove scaffold with no live importers (verified withrgacross@/,~/, relative paths, configs, and docs-as-config). Live memory API, auth forms, blog cards, nav, and polyfills are unchanged.Deleted
Duplicate memory API (
src/api/memory/**)_shared.ts, and unit tests undersrc/api/memory/(not wired to Astro; production contract issrc/pages/api/memory/**).apps/web/src/api/memory/__tests__/**/*.test.tsglob from rootvitest.config.ts.Legacy auth components
Login.tsx,Register.tsx,AuthButtons.tsx,AuthCard.astro,RequireRole.tsx— pages useLoginForm/RegisterForm;auth/index.tsonly exportsProtectedRoute.Orphan blog UI
ArticleCard,ArticleHeader,AuthorBio,Divider,Pagination,SeriesNavigation,SocialShare,Subscribe,TableOfContents(.astro), plusBlogSearch.tsx.PostCard.astro(imported bypages/blog/series/[name].astroandpages/blog/tag/[tag].astro).Todo demos
TodoAlpine.astro,TodoComponent.astro,TodoIsland.astro,TodoPreactIsland.astro,TodoReact.tsx— self-contained demo chain with no page importers.scripts/ci/tech-debt-baseline.json.Superseded layout / polyfill / shim
Navbar.astro,Hamburger.astro,Monitoring.astro— docs use@/components/mizu/Navbar.astro; RUM usesmonitoring/RealUserMonitoring.astro.src/buffer-polyfill.js— live copy ispublic/polyfills/buffer-polyfill.js.analytics/PatternVisualization.tsxre-export shim — tests and app code importPatternVisualizationReact.tsxdirectly.Committed Playwright artifacts
apps/web/public/test-results/**(62error-context.mdfiles).apps/web/public/test-results/to.gitignore.Test maintenance
source-map.test.mjs: example path updated tomizu/Navbar.astroafter deleting rootNavbar.astro.Kept (live importers)
src/pages/api/memory/**vercel.jsonrewrite + route-config auth rules@/pages/api/memory/_sharedcomponents/auth/LoginForm.tsx,RegisterForm.tsx,ProtectedRoute.tsx, …login.astro/register.astrocomponents/blog/PostCard.astrocomponents/mizu/Navbar.astroDocumentationLayout.astrocomponents/analytics/PatternVisualizationReact.tsxpublic/polyfills/buffer-polyfill.jsclient-entry.js/ feature detectorNote: Some
content-store/blog/*.mdfiles contain<ArticleCard>-style tags, but nothing registers those components for Markdown rendering and no TS/Astro importer references the deleted.astrofiles — tags were inert.Proof
pnpm lintpnpm buildpnpm vitest run -c config/vitest.config.tsVitest baseline (
staging, before changes)10 failing test files (25 failing tests):
apps/web/src/lib/audit/__tests__/chain.test.tsapps/web/src/lib/audit/__tests__/logger.test.tsapps/web/src/lib/db/__tests__/db-ssl-config.test.tsapps/web/src/lib/ehr-native/auth/ehr-rbac.test.tsapps/web/src/lib/governance/__tests__/compliance-validator.test.tsapps/web/src/lib/governance/__tests__/fhe-integration.test.tsapps/web/src/lib/graphql/__tests__/graphql.test.tsapps/web/src/api/routes/__tests__/auth.test.tsapps/web/src/tests/api/session/skills-api.test.tsapps/web/src/components/ai/chat/__tests__/useChatCompletion.test.tsBaseline summary: 10 failed | 474 passed | 2 skipped (486 files); 6920 tests passed.
Vitest on this branch
Same 10 failing files (no additions). Summary: 10 failed | 471 passed | 2 skipped (483 files) — three fewer files because deleted
src/api/memory/__tests__/*are gone. 6884 tests passed (−36 tests from removed memory unit tests).Net diff
101 files, +9 / −19,679 lines (commit stat).
Out of scope
Summary by Sourcery
Clean up unreferenced web application code and generated artifacts while preserving the live routes, components, and polyfills.
Enhancements:
CI:
Tests:
Chores: