Repository navigation
chore(deps): bump astro to 7.4.x and rebuild its patch - #6435
Merged
Merged
Conversation
astro 7.4 imports transformWithOxc from vite, so it needs the vite 8 workspace from the migration PR. 7.4 also reformatted dist/core/build/plugins/plugin-manifest.js (tabs), so the existing versionless astro patch no longer applies; rebuild it against 7.4 with the same two guards (missing PAGE_SCRIPT_ID entry).
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR upgrades Astro to 7.4.2 for compatibility with the Vite 8 workspace, rebuilds its patch against the changed upstream layout without altering the two existing PAGE_SCRIPT_ID safeguards, and refreshes lockfile resolutions and patch metadata. Review the patch semantics, lockfile consistency, and installation/build verification in CI. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
px Advisor ReviewRisk: unknown No summary available No findings. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="package.json" line_range="475" />
<code_context>
"@vitest/eslint-plugin": "^1.6.27",
"agents": "^0.28.1",
- "astro": "^7.3.5",
+ "astro": "^7.4.2",
"astro-eslint-parser": "^3.2.0",
"astro-robots-txt": "^1.0.0",
</code_context>
<issue_to_address>
**Astro stack guidance becomes stale**
When the updated dependency and lockfile are used, the dependency now resolves to Astro 7 while the repository records Astro 6 as its frontend stack, so maintainers following that guidance get an outdated platform description.
Update the Astro version in the corresponding repository knowledge entry to reflect the new stack.
</issue_to_address>Sourcery assessment
Approved.
| "@vitest/eslint-plugin": "^1.6.27", | ||
| "agents": "^0.28.1", | ||
| "astro": "^7.3.5", | ||
| "astro": "^7.4.2", |
Contributor
There was a problem hiding this comment.
⚪ Low · Astro stack guidance becomes stale
When the updated dependency and lockfile are used, the dependency now resolves to Astro 7 while the repository records Astro 6 as its frontend stack, so maintainers following that guidance get an outdated platform description.
Update the Astro version in the corresponding repository knowledge entry to reflect the new stack.
Prompt for AI agents
In `package.json` at line 475:
**Astro stack guidance becomes stale**
When the updated dependency and lockfile are used, the dependency now resolves to Astro 7 while the repository records Astro 6 as its frontend stack, so maintainers following that guidance get an outdated platform description.
Update the Astro version in the corresponding repository knowledge entry to reflect the new stack.From AGENTS.md L92:
- **Frontend / SSR**: Astro 6 + React 19 (TypeScript, Tailwind CSS)
Lighthouse CI ResultsRoutes audited: Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85 Reports
|
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps astro to 7.4.x on top of the vite 8 workspace (#6434) and rebuilds the astro patch for the new upstream layout.
transformWithOxcfrom vite, so it requires the vite 8 migration that just landed on staging.dist/core/build/plugins/plugin-manifest.js(tabs + shifted hunk offsets), so the existing versionlesspatches/astro.patchno longer applies (ERR_PNPM_PATCH_FAILED). The patch is rebuilt against 7.4 with the same two guards (missingPAGE_SCRIPT_IDentry).Why
This is the unblocker for dependabot #6419 (dev-deps group), which cannot install or build until staging is on astro 7.4 with a matching patch.
Verification
pnpm install --frozen-lockfileapplies the rebuilt patch (newpatch_hashrecorded in the lockfile);pnpm install --lockfile-only --frozen-lockfilepasses.pnpm run buildcompletes locally under node 24 with astro 7.4.4 + vite 8.3.5.Summary by Sourcery
Upgrade Astro to 7.4.x and rebuild its patch for the updated upstream distribution layout.
Bug Fixes:
Enhancements: