Skip to content

fix: don't ignore join_next() errors in background_fetch_any() #8686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
link2xt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: don't ignore join_next() errors in background_fetch_any() #8686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/scheduler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ impl SchedulerState {
}

while let Some(fetched) = set.join_next().await {
if let Ok(true) = fetched {
if fetched.context("background_fetch_any: Failed to join a task")? {

@hpk42 hpk42 Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASFAIU the error case can not happen in a release build: if join_next fails the whole process dies before it bubbles here. And if it happens in non-release builds, we should maybe just log an error?

break;
}
}
Expand Down