Conversation
link2xt
force-pushed
the
link2xt/try-join-next
branch
from
September 14, 2026 00:55
134010f to
b59d511
Compare
join_next() failing means something went really wrong, e.g. panic inside a task. We also don't cancel the tasks other than by dropping JoinSet, so join_next() should never return an error.
link2xt
force-pushed
the
link2xt/try-join-next
branch
from
September 14, 2026 01:03
b59d511 to
8acdda4
Compare
link2xt
marked this pull request as ready for review
September 14, 2026 01:07
hpk42
reviewed
Sep 14, 2026
|
|
||
| while let Some(fetched) = set.join_next().await { | ||
| if let Ok(true) = fetched { | ||
| if fetched.context("background_fetch_any: Failed to join a task")? { |
Contributor
There was a problem hiding this comment.
ASFAIU the error case can not happen in a release build: if join_next fails the whole process dies before it bubbles here. And if it happens in non-release builds, we should maybe just log an error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
join_next() failing means something went really wrong, e.g. panic inside a task. We also don't cancel the tasks other than by dropping JoinSet, so join_next() should never return an error.
Follow-up to #8592