Tabbed details dialog: Turn, Session, History (0.5.0) - #6
Merged
Merged
Conversation
…eight, width and padding
… engine figures; keep lines clear of the scrollbar
…ue shares, units; tidy the history table
…one value column, wider padding at xlarge
…s, colours and padding; spread the history columns
…lance top padding; reserve the scrollbar only when scrolling
…bars, charts kept together; show tool use or why not
…p the body indent option
…r the scrollbar; xlarge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds the details dialog as tabs, laid out from the approved mockups. Ships as 0.5.0.
What changes
tab/shift+tab./headsup sessionand/headsup historyopen those tabs; asking for the open tab closes the dialog, another tab switches to it.ctrl+shift+hopens it. Fixed columns spread across the width, never wrapped;sswitches this session / all sessions (all adds a model column); cost and cache columns only when some turn has them. The panel's code stays for one release, unused.xlarge, height fitted to content (up to 75% of the screen), a lighter panel inside the dialog's darker ring, a blank row under each section title, square bars, figures on shared columns (Tokens; a three-column engine grid). Colours are the mockup's on a dark theme, contrast-picked from the theme on a light one.dialog.ts(pure): all three tabs as styled lines; the entry file only draws them.Verified
npm test(unit + e2e) andtsc --noEmitpass.largeis 88 cells; the dialog pads its own top by a row; a full-width line that overflows wraps onto a blank-looking row.Not yet
dialog.tsand the tabbed dialog, as a separate pass (per the testing rules in AGENTS.md).