Skip to content

Prevent Windows min/max macro collisions - #317

Open
ethanmusser wants to merge 1 commit into
carnegierobotics:masterfrom
ethanmusser:ethanmusser/bug/fix-windows-minmax-collision
Open

ethanmusser wants to merge 1 commit into
carnegierobotics:masterfrom
ethanmusser:ethanmusser/bug/fix-windows-minmax-collision

Conversation

@ethanmusser

Copy link
Copy Markdown
Contributor

Define NOMINMAX on Windows to prevent the Windows SDK min/max macros from colliding with the similarly-named standard library functions.

Fixes build errors seen in Windows CI (e.g., this run). The relevant portion of the error is duplicated below.

    Building Custom Rule D:/a/LibMultiSense/LibMultiSense/source/Utilities/LibMultiSense/ThermalUtility/CMakeLists.txt
    ThermalUtility.cc
  D:\a\LibMultiSense\LibMultiSense\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.cc(169,55): error C2220: the following warning is treated as an error [C:\Users\runneradmin\AppData\Local\Temp\tmp8mevnqor\build\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.vcxproj]
  D:\a\LibMultiSense\LibMultiSense\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.cc(169,55): warning C4003: not enough arguments for function-like macro invocation 'max' [C:\Users\runneradmin\AppData\Local\Temp\tmp8mevnqor\build\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.vcxproj]
  D:\a\LibMultiSense\LibMultiSense\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.cc(169,55): error C2589: '(': illegal token on right side of '::' [C:\Users\runneradmin\AppData\Local\Temp\tmp8mevnqor\build\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.vcxproj]
  D:\a\LibMultiSense\LibMultiSense\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.cc(169,55): error C2059: syntax error: ')' [C:\Users\runneradmin\AppData\Local\Temp\tmp8mevnqor\build\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.vcxproj]
  D:\a\LibMultiSense\LibMultiSense\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.cc(170,55): warning C4003: not enough arguments for function-like macro invocation 'min' [C:\Users\runneradmin\AppData\Local\Temp\tmp8mevnqor\build\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.vcxproj]
  D:\a\LibMultiSense\LibMultiSense\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.cc(170,55): error C2589: '(': illegal token on right side of '::' [C:\Users\runneradmin\AppData\Local\Temp\tmp8mevnqor\build\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.vcxproj]
  D:\a\LibMultiSense\LibMultiSense\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.cc(170,55): error C2059: syntax error: ')' [C:\Users\runneradmin\AppData\Local\Temp\tmp8mevnqor\build\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.vcxproj]
  D:\a\LibMultiSense\LibMultiSense\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.cc(175,24): error C2589: '(': illegal token on right side of '::' [C:\Users\runneradmin\AppData\Local\Temp\tmp8mevnqor\build\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.vcxproj]
  D:\a\LibMultiSense\LibMultiSense\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.cc(175,24): error C2059: syntax error: ')' [C:\Users\runneradmin\AppData\Local\Temp\tmp8mevnqor\build\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.vcxproj]
  D:\a\LibMultiSense\LibMultiSense\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.cc(176,24): error C2589: '(': illegal token on right side of '::' [C:\Users\runneradmin\AppData\Local\Temp\tmp8mevnqor\build\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.vcxproj]
  D:\a\LibMultiSense\LibMultiSense\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.cc(176,24): error C2059: syntax error: ')' [C:\Users\runneradmin\AppData\Local\Temp\tmp8mevnqor\build\source\Utilities\LibMultiSense\ThermalUtility\ThermalUtility.vcxproj]
    Building Custom Rule D:/a/LibMultiSense/LibMultiSense/source/Utilities/LibMultiSense/VersionInfoUtility/CMakeLists.txt
    VersionInfoUtility.cc
       Creating library C:/Users/runneradmin/AppData/Local/Temp/tmp8mevnqor/build/source/Utilities/LibMultiSense/VersionInfoUtility/Release/VersionInfoUtility.lib and object C:/Users/runneradmin/AppData/Local/Temp/tmp8mevnqor/build/source/Utilities/LibMultiSense/VersionInfoUtility/Release/VersionInfoUtility.exp
    VersionInfoUtility.vcxproj -> C:\Users\runneradmin\AppData\Local\Temp\tmp8mevnqor\build\source\Utilities\LibMultiSense\VersionInfoUtility\Release\VersionInfoUtility.exe
  Traceback (most recent call last):
    File "C:\Users\runneradmin\AppData\Local\Temp\pip-build-env-oinuxcrx\overlay\Lib\site-packages\scikit_build_core\build\wheel.py", line 544, in _build_wheel_impl_impl
      build_wheel(builder)
    File "C:\Users\runneradmin\AppData\Local\Temp\pip-build-env-oinuxcrx\overlay\Lib\site-packages\scikit_build_core\build\common_wheel_helpers.py", line 313, in build_wheel
      builder.build(build_args=[])
    File "C:\Users\runneradmin\AppData\Local\Temp\pip-build-env-oinuxcrx\overlay\Lib\site-packages\scikit_build_core\builder\builder.py", line 495, in build
      self.config.build(
    File "C:\Users\runneradmin\AppData\Local\Temp\pip-build-env-oinuxcrx\overlay\Lib\site-packages\scikit_build_core\cmake.py", line 339, in build
      self._build(*local_args, *build_args)
    File "C:\Users\runneradmin\AppData\Local\Temp\pip-build-env-oinuxcrx\overlay\Lib\site-packages\scikit_build_core\cmake.py", line 350, in _build
      raise FailedLiveProcessError(msg) from None
  scikit_build_core.errors.FailedLiveProcessError: CMake build failed

@ethanmusser ethanmusser self-assigned this Oct 1, 2026
@ethanmusser ethanmusser added the bug Something isn't working label Oct 1, 2026
@ethanmusser ethanmusser changed the title fix(windows): prevent min/max macro collisions Prevent Windows min/max macro collisions Oct 1, 2026
@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ethanmusser
ethanmusser marked this pull request as ready for review October 1, 2026 19:09
@ethanmusser
ethanmusser enabled auto-merge (squash) October 5, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants