Skip to content

[DO NOT MERGE] Test combined CI fixes - #319

Draft
ethanmusser wants to merge 10 commits into
carnegierobotics:masterfrom
ethanmusser:ethanmusser/test/2026-10-01-ci-various-fixes
Draft

ethanmusser wants to merge 10 commits into
carnegierobotics:masterfrom
ethanmusser:ethanmusser/test/2026-10-01-ci-various-fixes

Conversation

@ethanmusser

@ethanmusser ethanmusser commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Combines #315, #316, #317, #318, and #320 in a single branch to see if CI issues are resolved. This is purely for testing. Don't merge this, merge the individual PRs.

@ethanmusser ethanmusser self-assigned this Oct 1, 2026
@ethanmusser ethanmusser added the invalid This doesn't seem right label Oct 1, 2026
@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

This header is required due to usage of `std::abs` in this source file.
@ethanmusser

Copy link
Copy Markdown
Contributor Author

FYI @mattalvarado: I think this combination of changes should fix all of the current CI failures. So I would treat #315, #316, #317, #318, and #320 all as valid/functional changes assuming you agree with them otherwise.

In general, seems like these CI failures fell into a few categories:

  • Dependency version bump (OpenCV bumped to >=5) caused CMake configuration failure.
  • Compiler version bump (macOS Homebrew-installed LLVM bump to C++23) exposed transitive dependencies that we were relying on.

In either case, these issues were only discovered because the CI does not pin these dependencies and compiler standards. But at the same time the CI began failing as a result of the silent version bumps. Not sure if you have any opinions on whether these things should be fixed rigidly or if you prefer using the latest-and-greatest even if silent CI failures will crop up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant