Support OpenCV 5 feature component - #315
Open
ethanmusser wants to merge 2 commits into
Open
ethanmusser wants to merge 2 commits into
ethanmusser wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ethanmusser
marked this pull request as ready for review
October 1, 2026 19:09
ethanmusser
enabled auto-merge (squash)
October 5, 2026 16:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CMake to deduce the correct OpenCV features component based on the detected OpenCV version. This makes the build compatible with
OpenCV>=5.Resolves most of the currently-failing macOS CI builds (the failure was due to the CI build sourcing a newer OpenCV version).
Note that this change also removes the fail-safe for the
BUILD_OPENCVCMake option. Previously, ifBUILD_OPENCV=ONbut OpenCV was not found with all of the required components, the build would proceed and simply omit the OpenCV portions. With this change, that same scenario results in a configuration failure. Let me know if you preferred the old way, but IMO it could easily lead to build configurations that did not match what the user expected.