Add coverage for errors, keys, content properties and Azure and S3 operations - #3
Merged
Merged
Conversation
…med only in the body, unusual keys, content properties, date conditions, and Azure and S3 operations from copies to leases, and send responses chunked or cut short where a case asks. A case can end with optional exchanges, such as retries, and every new request path is verified against Azure, S3 and S3 Express. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…the new cases. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…piping its output into tail hid. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…without its lease ID, which Azure refuses with 412 LeaseIdMissing although the condition holds. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…reports a 412 LeaseIdMissing as the service failure it is. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…e ignores, as a refusal must, so an adapter that reports every call unsupported passes none of those cases. An entry of the expected-unsupported list may be a pattern, such as operations/s3/*, which covers every case it matches. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
… which dropped every entry that was not a case ID. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…against this revision's list patterns. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…/value/content_md5_base64, which covers every case whose expectations require it, for a client that cannot report that field. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
… declared fields whose absence made a case unsupported, so a case that passes another way, such as by a refusal, stays a pass. A field entry that covers no case of a run over the whole suite is a mismatch. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…against this revision's field entries. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Collaborator
Author
|
Well, I did ask before merging the previous PR whether we wouldn't have a lot of churn afterwards, turns out that was wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New cases, each request path verified live against Azure (flat and HNS), S3 and S3 Express:
?,#,%,+, a space, non-ASCII text,//and a trailing/, on write, HEAD, delete, stage and commit.LeaseIdMissingalthough the condition holds), tags, access tiers, append blobs and page blobs, and S3 tagging and storage classes.The grader gains what these cases need: optional trailing exchanges (retries, a resumed download), chunked and cut-short responses, and a response written in one piece. Two grading changes:
unsupportedresult names that parameter, as a refusal must. Before, anyunsupportedpassed those cases.*matches any run of characters, such asoperations/s3/*. An entry may also name a result field, such asfield:/value/content_md5_base64: it covers the cases that the adapter left unsupported only by declaring such fields unsupported, which a report now lists asunsupported_fields. Every case an entry covers must be unsupported, and a field entry that covers no case of a whole-suite run is a mismatch.--record-unsupportedkeeps patterns and field entries and lists only the cases they miss.The example-adapter step now fails when the grader fails; piping into
tailhid that. The example adapter pins borink-org/object-storage#34, so merge that first, with a merge commit.