Skip to content

Add coverage for errors, keys, content properties and Azure and S3 operations - #3

Merged
tiptenbrink merged 11 commits into
masterfrom
coverage-additions
Sep 26, 2026
Merged

tiptenbrink merged 11 commits into
masterfrom
coverage-additions

Conversation

@tiptenbrink

@tiptenbrink tiptenbrink commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

New cases, each request path verified live against Azure (flat and HNS), S3 and S3 Express:

  • Error responses: Azure error codes named only in the XML body; server errors and throttling with up to five retries; S3 301 and 307 redirects.
  • Response framing: answers chunked where the service chunks them, and a body that ends before its Content-Length.
  • Unusual keys: ?, #, %, +, a space, non-ASCII text, // and a trailing /, on write, HEAD, delete, stage and commit.
  • Write options: Content-Type, Content-Encoding (stored gzip), Content-Language, Content-Disposition and Cache-Control, read back by GET and HEAD, and If-Modified-Since and If-Unmodified-Since.
  • Operations: copies, batch deletes, containers and buckets, Azure leases (including a conditional write or delete to a leased blob, which Azure refuses with 412 LeaseIdMissing although the condition holds), tags, access tiers, append blobs and page blobs, and S3 tagging and storage classes.

The grader gains what these cases need: optional trailing exchanges (retries, a resumed download), chunked and cut-short responses, and a response written in one piece. Two grading changes:

  • A decline of a case whose parameter the service ignores passes only when the adapter's unsupported result names that parameter, as a refusal must. Before, any unsupported passed those cases.
  • An entry of the expected-unsupported list may be a pattern, where * matches any run of characters, such as operations/s3/*. An entry may also name a result field, such as field:/value/content_md5_base64: it covers the cases that the adapter left unsupported only by declaring such fields unsupported, which a report now lists as unsupported_fields. Every case an entry covers must be unsupported, and a field entry that covers no case of a whole-suite run is a mismatch. --record-unsupported keeps patterns and field entries and lists only the cases they miss.

The example-adapter step now fails when the grader fails; piping into tail hid that. The example adapter pins borink-org/object-storage#34, so merge that first, with a merge commit.

tiptenbrink and others added 8 commits September 26, 2026 12:42
…med only in the body, unusual keys, content properties, date conditions, and Azure and S3 operations from copies to leases, and send responses chunked or cut short where a case asks. A case can end with optional exchanges, such as retries, and every new request path is verified against Azure, S3 and S3 Express.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…the new cases.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…piping its output into tail hid.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…without its lease ID, which Azure refuses with 412 LeaseIdMissing although the condition holds.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…reports a 412 LeaseIdMissing as the service failure it is.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…e ignores, as a refusal must, so an adapter that reports every call unsupported passes none of those cases. An entry of the expected-unsupported list may be a pattern, such as operations/s3/*, which covers every case it matches.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
… which dropped every entry that was not a case ID.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…against this revision's list patterns.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
tiptenbrink and others added 3 commits September 26, 2026 19:35
…/value/content_md5_base64, which covers every case whose expectations require it, for a client that cannot report that field.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
… declared fields whose absence made a case unsupported, so a case that passes another way, such as by a refusal, stays a pass. A field entry that covers no case of a run over the whole suite is a mismatch.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…against this revision's field entries.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@tiptenbrink

tiptenbrink commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator Author

Well, I did ask before merging the previous PR whether we wouldn't have a lot of churn afterwards, turns out that was wrong.

@tiptenbrink
tiptenbrink merged commit bb4523e into master Sep 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant