Grade the crates against the new object-tests cases - #34
Merged
Merged
Conversation
…rts a call field it does not map, an operation the crate lacks and a response header the crate does not read as unsupported, and the list records those cases; the four cases where Azure answers a leased blob with 412 LeaseIdMissing stay wrong, since the crate treats that answer as a fault. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
… names one. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…se cases, which the crates now pass. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…ry S3 case and every lease operation, which cuts the list from 535 entries to 121. Grade against the object-tests revision that reads those patterns and credits a range decline only when the adapter names the range. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
…he crate does not read by field, not by case, which cuts the list to 70 entries. Grade against the object-tests revision that reads field entries. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
grade.shto object-tests master, which now has the new cases (borink-org/object-tests#3), and updates the adapter to match:expected-unsupported.jsonnames whole categories with patterns, such asoperations/s3/*andoperations/azure*/lease-*, and the response headers the crate does not read with field entries, such asfield:/value/content_md5_base64. That cuts it from 535 entries to 70. With #35 merged in, the crates pass every case they support, including the lease cases, andgrade.shreports no mismatch.object-tests master builds its example adapter from a commit on this branch, so merge with a merge commit, which keeps that commit reachable.