Repository navigation
feat(feedback): adopt merged upstream adapter capabilities - #127
Merged
Merged
Conversation
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HIG feedback roots can now pass independent abort signals to the merged SFX engine, so cancel/mute/background/dispose stop that root’s voices while other roots and host-owned playback continue. The browser haptic adapter also accepts the merged
canTriggerHaptic/triggerHapticfunctions through an optional injected backend, probing current capability without a new eager import.Stacked on #126 (
hig/roadmap-followups); this diff contains only feedback adapters, focused integration/boundary tests, documentation and evidence. Refs #70.Validation: full Node 22.22 check passed (174 web / 161 native tests, build/lint/types/docs); 23 focused tests include 11 cases against exact MIT upstream sources and actual released 0.1.0. SSR, clean packed consumers and the injectable haptic entry without React/SFX/Haptic peers pass. Source pins, licenses, hashes and logs are in
tests/fixtures/upstream-feedback/andevidence/feedback/issue-70/report.json.Published SFX 0.1.0 ignores the extra signal and still cannot stop an active voice; published Haptic 0.1.0 lacks the imperative exports. Released adoption remains pending. iOS imperative haptics remain unavailable, browser vibration cancellation remains document-wide, and physical output/latency certification is unchanged. No dependencies/lock, coordinated candidate, release, deployment or device actuation changed. Remote CI is pending at draft creation.