Repository navigation
feat(feedback): adopt @bloxwap/sfx and @bloxwap/haptic 0.2.0, drop 0.1.0 workarounds - #128
Merged
Merged
Conversation
- Update dependencies to ^0.2.0 for both sfx and haptic packages - Remove upstream-feedback fixtures that were vendored for unreleased APIs - Update tests to use published APIs directly - Remove 0.1.0 compatibility workarounds from documentation - Update evidence documentation to reflect published packages Co-authored-by: Joe Blau <[email protected]>
- Create tests/test-utils/fake-audio.ts for Web Audio API mocking - Update feedback-upstream tests to use local test utilities - Fix haptic test to track vibrate calls correctly without spying on ES module exports Co-authored-by: Joe Blau <[email protected]>
…@^0.2.0 - Update native and web fixtures to match feedback package peer dependencies - Fixes native smoke test peer dependency conflicts Co-authored-by: Joe Blau <[email protected]>
…/haptic@^0.2.0 - Fixes ERESOLVE peer dependency conflict in packed consumer smoke test Co-authored-by: Joe Blau <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #127. Now that
@bloxwap/[email protected]and@bloxwap/[email protected]are published, this does the following:^0.2.0and updates the lockfile.tests/fixtures/upstream-feedback/sources. The tests now run against the published packages, andfake-audio.tsis moved totests/test-utils.docs/feedback/adapters.md,packages/feedback/README.mdand the issue-70 evidence.scripts/packed-smoke.mjs, which still had 0.1.0 hardcoded.All checks were green on
c4ca8da.