Repository navigation
Feedback & Wissenslücken, Antwortqualität, Aktualität, S3 Vectors, Admin-Statistik - #471
Merged
Merged
Conversation
Retrieval returns source_job_id with every hit and serves POST /api/v1/passage (cited chunk plus neighbours, same visibility rules as search). The eval harness adds Precision@k, nDCG@k, --json output and an optional answer: block in golden files. Runtime carries source_job_id, heading_path and chunk_index on sources and adds python -m app.eval_cli answers: model comparison scoring retrieval, correctness and grounding separately. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01W9t7FekLfn8nPUJLW1BkgU
Weave-API returns the assistant message id, stores helpful/wrong/outdated ratings per user and forwards anonymous quality signals (feedback and unanswered questions) to Weave-Ingest through an outbox. GET /v1/sources/passage proxies the passage lookup within the caller's read rights. The chat shows feedback buttons and a passage dialog opened from citation markers and source cards. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01W9t7FekLfn8nPUJLW1BkgU
Ingest clusters unanswered questions and turns them, wrong/outdated feedback, due reviews and possible contradictions into Pruefaufgaben for the owners and members of a space. Documents get review dates (frontmatter review_due or space interval) with a reminder tick and the document.review_due webhook, section-wise version diffs, topic subscriptions and a change feed. Knowledge reports possible contradictions between similar passages after indexing. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01W9t7FekLfn8nPUJLW1BkgU
Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01W9t7FekLfn8nPUJLW1BkgU
VECTOR_BACKEND=s3vectors (per service, pgvector stays the default) makes Weave-Knowledge mirror chunk embeddings into an S3 Vectors index (best effort; s3vectors init/sync/status CLI repairs drift) and Weave-Retrieval take vector candidates from it. Every candidate is rechecked in Postgres with the same rights, status and model filters as the pgvector path, so a stale index cannot widen access; on S3 errors Retrieval falls back to pgvector. Wired through weave.yaml, compose, the Helm chart and weave_config check; ADR 0010 and betrieb.md 7.8 describe rollout order, IAM actions and region handling. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01W9t7FekLfn8nPUJLW1BkgU
Weave-Knowledge serves GET /api/v1/internal/stats (documents by status, chunks, embedding models, knowledge spaces, memory summaries, vector backend, table sizes on PostgreSQL), guarded like reindex/status. Weave-Ingest adds GET /api/v1/admin/statistics (admin only) with documents, versions, releases, stored objects per backend, spaces, users, teams, review tasks and subscriptions, and includes the Knowledge figures (null with a reason when Knowledge is unreachable). The admin overview shows them in a new Statistik section. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01W9t7FekLfn8nPUJLW1BkgU
…Vectors - API: prune outbox rows after 30 days also without Ingest config, drain a backlog in one flush, retract queued signals (without text) when a conversation is deleted - Ingest: resend pending document.review_due webhooks on the next tick, announce only delivered releases in the change feed, bound and cache gap clustering candidates per batch - Retrieval: follow QueryVectors pagination - Knowledge: run the S3 Vectors mirror and the contradiction check in their own post-index task Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01W9t7FekLfn8nPUJLW1BkgU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the three planned feature packages plus two follow-ups:
1. Feedback und Wissenslücken
message_idin/v1/chatand in thedoneSSE event.QUALITY_SIGNALS_ENABLED=falseturns forwarding off./pruefaufgabenwith a badge and a quality summary.2. Antwortqualität sichtbar machen
POST /api/v1/passageserves it with the same visibility rules as search; the API proxies it asGET /v1/sources/passage.source_job_id,heading_pathandchunk_index.--jsonoutput, and golden entries can carry ananswer:block.python -m app.eval_cli answersin Runtime compares models on the same golden set. It scores retrieval, factual correctness (key facts, token F1, optional LLM judge) and grounding (faithfulness, citation coverage and precision) separately, plus abstention.3. Aktualität und Änderungen
review_dueor a space interval. A reminder tick creates a Prüfaufgabe and sends the new webhook eventdocument.review_due./reviews/[id]/changes)./aenderungen, including the search "Was hat sich an … geändert?".4. Amazon S3 Vectors (optional vector index, ADR 0010)
KNOWLEDGE_VECTOR_BACKEND/RETRIEVAL_VECTOR_BACKEND=pgvector(default) ors3vectors.s3vectors init/sync/status.weave.yaml, compose, the Helm chart andweave_config.py check.5. Admin-Statistik
GET /api/v1/admin/statistics(Ingest) andGET /api/v1/internal/stats(Knowledge).Affected services
services/api, services/chat, services/runtime, services/retrieval, services/knowledge, services/ingest (backend + frontend), contracts/, deploy/, scripts/, docs/, README.md
New migrations:
0009_message_feedback0062_quality_review_tasks,0063_document_freshnessKnowledge has no schema change.
Test plan
pytest— 476 passedpytest— 686 passedpytest— 260 passedpytest— 424 passedpytest— 1591 passed, 2 skippedvitest,npm run lint,npm run typecheck— greenvitest(407),npm run lint(0 errors),npm run typecheck— greenscripts/tests— 70 passed, 9 skipped (helm not available locally)helm template+scripts/check_chart_env.py(helm could not be run in the authoring environment)Checklist
contracts/updated if an API or event changed (openapi.jsonregenerated, additions only;internal-chat.md,chunk-store.md,frontmatter.schema.json,events/document.review_due.md)python scripts/weave_config.py checkpasses if configuration changeddocs/updated if operators or users see the change (ADR 0010,betrieb.md§7.8, README)deploy/.envin the diffNotes for reviewers
init+sync, then switch Retrieval.weave_config.py checkflags the wrong order. SetS3VECTORS_REGIONexplicitly; botocore reads neitherAWS_REGIONnor instance metadata.Generated by Claude Code