Default PR-review-notification reusable runner to codebuild - #4
Merged
Conversation
Flip the `runner` input default from `ubuntu` to `codebuild` so callers that don't pass `runner` use the self-hosted CodeBuild fleet by default. Callers can still force GitHub-hosted runners with `runner: ubuntu`.
Hweinstock
approved these changes
Sep 9, 2026
jariy17
pushed a commit
to aws/agentcore-cli
that referenced
this pull request
Sep 9, 2026
Point at 70f0e50 (merged aws/agentcore-devx-devtools#4) instead of the pre-merge branch commit.
jariy17
added a commit
to aws/agentcore-cli
that referenced
this pull request
Sep 10, 2026
* Bump PR-review-notification reusable to codebuild-default pin Point the caller at the agentcore-devx-devtools commit whose reusable workflow defaults `runner` to codebuild, moving PR-review Slack notifications onto the self-hosted CodeBuild fleet. * Re-pin to devtools main SHA after #4 merged Point at 70f0e50 (merged aws/agentcore-devx-devtools#4) instead of the pre-merge branch commit. --------- Co-authored-by: jariy17 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Flip the
runnerinput default inreusable-slack-pr-review-notification.ymlfromubuntu→codebuild.Why
Callers of this reusable workflow that don't explicitly set
runnercurrently fall back to GitHub-hostedubuntu-latest. Defaulting tocodebuildmoves PR-review Slack notifications onto the self-hosted CodeBuild fleet without every caller having to opt in. Callers can still force GitHub-hosted withrunner: ubuntu.Blast radius / follow-ups
...reusable-slack-pr-review-notification.yml@<SHA>to this commit.agentcore-e2eCodeBuild project provisioned, or its notify job will hang unscheduled.aws/agentcore-clialready has it; verify the other caller repos before bumping their pins.No behavior change to the notification logic itself — runner selection only.