Move PR-review Slack notifications to CodeBuild runner - #2261
Merged
Conversation
Point the caller at the agentcore-devx-devtools commit whose reusable workflow defaults `runner` to codebuild, moving PR-review Slack notifications onto the self-hosted CodeBuild fleet.
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
This PR just bumps the pinned SHA of the reusable aws/agentcore-devx-devtools Slack PR review notification workflow. Both the old and new commits resolve on the upstream repo, and the SHA is pinned (not a mutable ref), so the supply-chain hygiene is preserved. No code, tests, or telemetry to review — looks good to merge.
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Package TarballHow to installgh release download pr-2261-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.28.1.tgz |
Point at 70f0e50 (merged aws/agentcore-devx-devtools#4) instead of the pre-merge branch commit.
jariy17
marked this pull request as ready for review
September 9, 2026 21:36
Contributor
Coverage Report
|
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Hweinstock
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump the pinned SHA of the
reusable-slack-pr-review-notification.ymlshared workflow:...@626595f→...@9e85985.The only diff between those two commits in that file is the
runnerinput default flippingubuntu→codebuild. Norunner:argument is added — the caller inherits the new default, so the notify job now runs oncodebuild-agentcore-e2e-…instead ofubuntu-latest.9e85985is that PR's branch commit; if feat: Add tree-style summary display for agent and project creation #4 is squash-merged, re-pin to the resultingmainSHA before merging.agentcore-e2eCodeBuild project (already serves this repo's pr-automation — no infra work).To force GitHub-hosted again:
with: { runner: ubuntu }on thecalljob.