Skip to content

Move PR-review Slack notifications to CodeBuild runner - #2261

Merged
jariy17 merged 2 commits into
mainfrom
pin-codebuild-pr-review-notif
Sep 10, 2026
Merged

Move PR-review Slack notifications to CodeBuild runner#2261
jariy17 merged 2 commits into
mainfrom
pin-codebuild-pr-review-notif

Conversation

@jariy17

@jariy17 jariy17 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

What

Bump the pinned SHA of the reusable-slack-pr-review-notification.yml shared workflow: ...@626595f...@9e85985.

The only diff between those two commits in that file is the runner input default flipping ubuntucodebuild. No runner: argument is added — the caller inherits the new default, so the notify job now runs on codebuild-agentcore-e2e-… instead of ubuntu-latest.

⚠️ Draft — blocked on upstream

To force GitHub-hosted again: with: { runner: ubuntu } on the call job.

Point the caller at the agentcore-devx-devtools commit whose reusable
workflow defaults `runner` to codebuild, moving PR-review Slack
notifications onto the self-hosted CodeBuild fleet.
@github-actions github-actions Bot added the size/xs PR size: XS label Sep 9, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 9, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

This PR just bumps the pinned SHA of the reusable aws/agentcore-devx-devtools Slack PR review notification workflow. Both the old and new commits resolve on the upstream repo, and the SHA is pinned (not a mutable ref), so the supply-chain hygiene is preserved. No code, tests, or telemetry to review — looks good to merge.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 9, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.28.1.tgz

How to install

gh release download pr-2261-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.28.1.tgz

Point at 70f0e50 (merged aws/agentcore-devx-devtools#4) instead of the
pre-merge branch commit.
@jariy17
jariy17 marked this pull request as ready for review September 9, 2026 21:36
@jariy17
jariy17 requested a review from a team September 9, 2026 21:36
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 41.08% 15742 / 38319
🔵 Statements 40.34% 16790 / 41618
🔵 Functions 35.19% 2712 / 7705
🔵 Branches 34.24% 10526 / 30738
Generated in workflow #4465 for commit 123dddb by the Vitest Coverage Report Action

@github-actions github-actions Bot added size/xs PR size: XS and removed size/xs PR size: XS labels Sep 9, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 9, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 9, 2026
@jariy17
jariy17 merged commit 5b7a040 into main Sep 10, 2026
35 of 36 checks passed
@jariy17
jariy17 deleted the pin-codebuild-pr-review-notif branch September 10, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants