Repository navigation
build(typeorm)!: migrate workspace package releases - #15
Merged
Merged
Conversation
BREAKING CHANGE: SeederFactory.for now requires TypeORM ObjectLiteral entities.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Таска
TypeORM уже вызывает общий
atls/shared/.github/workflows/publish.yaml@master. Этот PR переводит корневой workspace сcode-runtimeна Raijin 2.1 и Yarn 4.18, оставляет прежний npm registry иpublishConfig.access: publicу обоих пакетов. Старые Husky hooks заменены штатными, решения о версиях записаны для каждого изменённого пакета.Изменение публичного типа: по согласованному решению
SeederFactory.for<Entity>теперь требуетEntity extends ObjectLiteral, как и TypeORM repository. Это major-выпуск@atls/[email protected];@atls/typeorm-loggerполучает patch1.0.2. Текущий@atls/[email protected]закрепляет прежнюю версию1.0.3и автоматически на major не переходит.Как проверять
node .yarn/releases/yarn.js install --immutableиnode .yarn/releases/yarn.js check --verify. Ожидаемый результат: установка, формат, lint и строгая проверка типов проходят без suppressions иskipLibCheck.node .yarn/releases/yarn.js workspaces foreach -A -t --no-private run prepack, затемnode .yarn/releases/yarn.js version checkиnode .yarn/releases/yarn.js version apply --all --dry-run. Ожидаемый результат: оба пакета собираются, версии запланированы как1.0.2и2.0.0.Publish to registry, npm metadata и tarball обеих версий, GitHub Releases и версии вmaster. До merge этот результат не подтверждён.Пруфы
check --verify, обе сборки, общийprepack,version checkи dry run завершились с кодом 0. В репозитории пока нет unit или integration test cases; эти стадииcheckпустыеtypeorm-seedingустановлен как локальный кандидат вместе с опубликованным@atls/[email protected]: строгий consumer typecheck безskipLibCheckпрошёл, временная SQL.js база сохранила сущность черезSeederFactory.forresolutions; это проверка совместимости исходного контракта, а не публикации будущей версии2.0.0