Skip to content

build(nestjs-typeorm-seeding)!: adopt TypeORM seeding 2 - #433

Merged
TorinAsakura merged 1 commit into
masterfrom
build/nestjs-typeorm-seeding-v2
Oct 13, 2026
Merged

TorinAsakura merged 1 commit into
masterfrom
build/nestjs-typeorm-seeding-v2

Conversation

@TorinAsakura

Copy link
Copy Markdown
Member

Task

This is the NestJS consumer follow-up to the TypeORM 2.0.0 release, kept under the existing ATLS package epic and reopened NestJS task. @atls/nestjs-typeorm-seeding reexports @atls/typeorm-seeding, so its dependency moves from 1.0.3 to 2.0.0 and the wrapper receives a major version decision (1.0.0) for the narrower public SeederFactory.for<Entity extends ObjectLiteral> type. The unused Jest dependency and package-level typecheckSkipLibCheck are removed; package Node typings match the root's Node 24. NestJS module registration and the TypeORM 0.3.20 dependency stay as they are.

How to verify

  1. Run node .yarn/releases/yarn.js install --immutable and node .yarn/releases/yarn.js check --verify with the project's Testcontainers Docker endpoint. Expected result: format, lint, typecheck and the repository's unit and integration suites pass.
  2. Run node .yarn/releases/yarn.js test unit packages/nestjs-typeorm-seeding/src/module/typeorm-seeding.module.test.ts and build/prepack the wrapper. Expected result: the Nest provider resolves the v2 SeederFactory, persists an entity and the package builds.
  3. Run node .yarn/releases/yarn.js version check and node .yarn/releases/yarn.js version apply --all --dry-run. Expected result: the wrapper is scheduled for 1.0.0 and unrelated workspaces do not get a version bump.
  4. After merge, verify the shared publisher, the released package's exact @atls/[email protected] dependency, npm tarball and GitHub Release. This delivery proof is pending merge.

Proofs

  • The focused NestJS module test and repository typecheck passed locally on the new dependency
  • TypeORM's 2.0.0 npm tarball and GitHub Release were verified against the merged TypeORM source
  • The wrapper's prepack archive contains exact @atls/[email protected] and builds without a package-level typecheck skip; the pre-existing root skip remains because unrelated vendor declarations fail under strict library checking
  • Staged source globs now exclude generated PnP and Yarn bundles while retaining packages, examples and the root project types file
  • Final full check --verify passed: format, lint, typecheck, 146 unit tests and 5 integration tests using remote Testcontainers; task-owned containers and tunnel were removed afterward

BREAKING CHANGE: the wrapper reexports SeederFactory.for with the ObjectLiteral entity constraint.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T05:28:42.899051Z 4a172bf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@TorinAsakura
TorinAsakura merged commit 398f835 into master Oct 13, 2026
1 check passed
@TorinAsakura
TorinAsakura deleted the build/nestjs-typeorm-seeding-v2 branch October 13, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant