Repository navigation
build(nestjs-typeorm-seeding)!: adopt TypeORM seeding 2 - #433
Merged
Merged
Conversation
BREAKING CHANGE: the wrapper reexports SeederFactory.for with the ObjectLiteral entity constraint.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
This is the NestJS consumer follow-up to the TypeORM 2.0.0 release, kept under the existing ATLS package epic and reopened NestJS task.
@atls/nestjs-typeorm-seedingreexports@atls/typeorm-seeding, so its dependency moves from1.0.3to2.0.0and the wrapper receives a major version decision (1.0.0) for the narrower publicSeederFactory.for<Entity extends ObjectLiteral>type. The unused Jest dependency and package-leveltypecheckSkipLibCheckare removed; package Node typings match the root's Node 24. NestJS module registration and the TypeORM0.3.20dependency stay as they are.How to verify
node .yarn/releases/yarn.js install --immutableandnode .yarn/releases/yarn.js check --verifywith the project's Testcontainers Docker endpoint. Expected result: format, lint, typecheck and the repository's unit and integration suites pass.node .yarn/releases/yarn.js test unit packages/nestjs-typeorm-seeding/src/module/typeorm-seeding.module.test.tsand build/prepack the wrapper. Expected result: the Nest provider resolves the v2SeederFactory, persists an entity and the package builds.node .yarn/releases/yarn.js version checkandnode .yarn/releases/yarn.js version apply --all --dry-run. Expected result: the wrapper is scheduled for1.0.0and unrelated workspaces do not get a version bump.@atls/[email protected]dependency, npm tarball and GitHub Release. This delivery proof is pending merge.Proofs
2.0.0npm tarball and GitHub Release were verified against the merged TypeORM source@atls/[email protected]and builds without a package-level typecheck skip; the pre-existing root skip remains because unrelated vendor declarations fail under strict library checkingcheck --verifypassed: format, lint, typecheck, 146 unit tests and 5 integration tests using remote Testcontainers; task-owned containers and tunnel were removed afterward