Repository navigation
feat: add P3 composition and performance - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P3 adds canonical scene editing and independent duplication, Tidal-clocked scene launches, scene arrangements with repeats/looping, Studio performance presentation, motion controls and managed-code drafts. HTTP, Studio, classic and MCP continue to use the same project service and command queue.
Launches prepare the affected tracks before one shared Tidal play-map replacement. The browser never advances scenes. A performance retains its launched composition until an explicit relaunch; mixer and tempo remain live. Project reopening now explicitly stops playback. Raw external mutation is visible and requires an explicit return to managed playback.
Validation on Ubuntu: 204 tests discovered, 201 passed, three existing Windows-only skips; build and both typechecks passed. Classic, Studio, P2, System and new P3 Chromium journeys passed, along with the real Linux Node runtime/ownership harness. P3 coverage includes explicit cycle fixtures, no-client observation, actual MCP reconnect, legacy synchronization, code draft failures, stale repeat edits, persistence and history. See docs/p3-composition-performance.md and docs/p3-validation.json for the full record and limitations.
This PR is intentionally stacked on feat/p2.6-ubuntu-portability at be2e730. P2.6 remains Level B — Ubuntu Runtime Safe, draft PR #4, unmerged, Windows revalidation pending. Its acceptance status is unchanged.
Keep this PR draft. Native GHCi/Tidal execution of the new helper, real Ubuntu audio/timing/recording and real Windows regression acceptance remain unvalidated. Portable fixtures and CI do not close those gates. Full native P3 acceptance is not complete. No P3.5, P4 or P5 work is included; no system/audio packages or pending kernel state were changed.
Final reviewed head:
7f5971ab603c33f893071839c5880b57ed8569f1. CI run 34078676385 passed on Ubuntu and Windows, including the P3 browser journey. This does not establish native audio or human desktop/console-flash acceptance.