Repository navigation
feat: add P3.5A Sound Lab Core - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Studio can generate and shape sounds through canonical synth tracks, five instruments, eight serial insert effects, engine-owned modulation and local patches. P3 compositional automation now also targets 14 deliberate FX controls by
fx.<instanceId>.<semanticParameter>. Reordering retains those targets; removal cleans matching lanes/routes atomically, and Undo restores them with the insert.Base values, P3 automation and continuous Sound Lab modulation remain separate authored layers. Tidal compiles silent control events alongside music in the existing track slot, including through rests. SuperDirt delivers those controls to persistent inserts under per-lane authorization, runtime generation, node and transport guards. SC selects automation or stored base, adds modulation, and clamps before DSP mapping. Disabling either movement layer preserves the other and base; stop/expiry release automation. Knobs communicate both states using the existing tactile controls. UI and MCP use the same canonical validation, revision guards, history and persistence.
Supported composition parameters: filter cutoff/resonance; distortion drive/mix; bitcrush bits/mix; reverb size/mix; delay feedback/mix; chorus depth/mix; compressor amount; ring mix. Sensitive time/rate/frequency parameters, compressor threshold and reverb damping remain deliberately excluded. Unsupported new targets are rejected clearly.
This is a stacked draft, based on exact P3 commit
7f5971ab603c33f893071839c5880b57ed8569f1and targetingfeat/p3-composition-performance. Dependencies #5 (P3) and #4 (P2.6) remain unmerged. Do not merge this PR as native-audio accepted.Validation on Ubuntu 24.04.4 with Node 24.14.0/npm 11.9.0:
Implementation scope is complete for P3.5A's supported surface. Native acceptance remains pending: no native SC/Tidal compilation, audible synthesis/FX quality, acoustic timing, CPU/node-lifetime or Windows desktop/audio acceptance is claimed. The new SuperDirt control-event path has source/contract and fixture coverage, not native execution evidence. P2.6 remains Ubuntu Runtime Safe with Windows revalidation pending; P3 native audio/timing acceptance remains pending.
Remaining limits: synth modulation phase starts per voice; source/note/automation-curve edits during prepared performance require relaunch, while disabling/removing FX automation releases immediately. Inserts/modulation/mixer/tempo remain live. User patches live in the current project. Unknown definitions/versions retain inert authored state. No P3.5B/P4/P5 features or system/audio package changes.
Architecture, supported controls, ownership/removal semantics, evidence and exit criteria: P3.5A completion report. Machine-readable results: validation summary.