Repository navigation
Test minimum dependency bounds - #103
Merged
Merged
Conversation
Member
|
@gselzer Thanks! I took a look at the requests source code; it seems that 2.16.0 is the first version that removed the vendored |
Contributor
Author
|
Thanks @ctrueden! Looks like we'll need an even newer version of |
Contributor
Author
|
How do you feel about the expansion of the matrix to test highest and lowest for both? We could |
gselzer
force-pushed
the
test-minimum-dependencies
branch
2 times, most recently
from
May 6, 2026 21:12
da52862 to
8df6bc7
Compare
gselzer
force-pushed
the
test-minimum-dependencies
branch
from
May 19, 2026 16:37
8df6bc7 to
b49d22d
Compare
ctrueden
force-pushed
the
test-minimum-dependencies
branch
2 times, most recently
from
October 23, 2026 20:55
a4c79d0 to
f9f4858
Compare
Add CI jobs that resolve direct dependencies to their declared lower bounds (UV_RESOLUTION=lowest-direct) on Python 3.10 across all three OSes, plus a `make test-lowest` target to do the same locally. Those jobs skip linting, since linting with the oldest dev tools says nothing about jgo's own bounds. Disable fail-fast so that one failing job (e.g. a network flake) does not cancel the others. Raise lower bounds to versions that actually pass: - psutil>=7 - requests>=2.30.0 (first version supporting urllib3 2) - rich>=14.3.0 (14.2.0 renders table titles differently) Dev tools also need floors, since lowest-direct applies to them too. Co-Authored-By: Claude Opus 5.5 <[email protected]>
ctrueden
force-pushed
the
test-minimum-dependencies
branch
from
October 23, 2026 20:59
f9f4858 to
10c335d
Compare
Member
|
@gselzer Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It'd be great to verify that jgo works with all of the dependency versions it claims to support. Of course, testing all combinations is infeasible, but we could test other combinations (namely, the minimum bound, in addition to the maximum bounds currently tested)
Note that this PR adds in a number of dependency bounds, namely:
psutil>=1- we just want a minimum bound, this one works despite being very old