Repository navigation
Use pytest-prysk instead - #104
Merged
Merged
Conversation
gselzer
force-pushed
the
pytest-prysk
branch
3 times, most recently
from
May 20, 2026 17:50
422b512 to
8e93dbe
Compare
Maybe. wrap has a little trouble still
Unlike the standalone prysk CLI, pytest-prysk does not point TMPDIR, TEMP and TMP at a fresh per-test directory. Many .t files write to and cd into "$TMPDIR", which is unset on most Linux systems (including CI runners), so it expanded to "" and seven tests failed (config, coords, info, javainfo, list, path, tree). On macOS, TMPDIR is set but shared, so state leaked between runs (e.g. path.t's non-idempotent mkdir). pytest-prysk items also do not participate in fixtures, so the autouse _isolate_config_file fixture never applied to .t tests. Add a pytest_runtest_call hook wrapper that, for prysk items only, sets TMPDIR/TEMP/TMP to a fresh temporary directory, defaults COLOR=never and NO_PROGRESS=1, and unsets JGO_CONFIG_FILE. This makes plain `uv run pytest` behave the same as bin/test.sh, so bin/test.sh no longer needs to set those variables. With a working $TMPDIR, the example.t workaround is no longer needed, so restore it to match main (its cleanup line still cds into $TMPDIR). Co-Authored-By: Claude Opus 5.5 <[email protected]>
ctrueden
force-pushed
the
pytest-prysk
branch
from
October 23, 2026 18:37
8e93dbe to
fcfa4a9
Compare
prysk runs .t files via /bin/sh, which Windows lacks. Previously, bin/test.sh only ran prysk when the prysk command was found, which never happened on the Windows CI runners, so the .t tests were silently skipped there. Now that pytest-prysk collects them, skip them explicitly. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The prysk tests now run via pytest-prysk under uv run, which puts the project venv's jgo first on the PATH. Co-Authored-By: Claude Opus 5.5 <[email protected]>
ctrueden
marked this pull request as ready for review
October 23, 2026 20:37
ctrueden
approved these changes
Oct 23, 2026
ctrueden
left a comment
ctrueden
left a comment
Member
There was a problem hiding this comment.
Excellent, thank you very much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was looking at adding it in #103 but it might be best to consider it separately first