Repository navigation
fix: run without proxy locally when Apify Proxy is not available - #1231
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1231 +/- ##
==========================================
+ Coverage 93.84% 93.93% +0.09%
==========================================
Files 54 54
Lines 3803 3828 +25
==========================================
+ Hits 3569 3596 +27
+ Misses 234 232 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…sword fetch fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a local run requests Apify Proxy and can't use it, the SDK now logs a warning and runs without a proxy instead of raising. On the Apify platform, the errors are unchanged. This matches the JS SDK, including apify/apify-sdk-js#824.
A local run falls back to no proxy in three cases:
password, not inAPIFY_PROXY_PASSWORD, and no token to fetch it with.connected: false.A timed-out status check still only logs a warning and keeps the proxy, as before.
Changes:
ProxyConfiguration.initialize()returnsbool. It returnsFalsewhen the run should proceed without a proxy. The access check is skipped when there is no password.Actor.create_proxy_configuration()returnsNonewheninitialize()returnsFalse.new_proxy_info()andnew_url()returnNone, so no proxy URL is built with an empty password.ApifyHttpProxyMiddleware(Scrapy) sends requests without a proxy in this case. It creates the proxy configuration only once, also for concurrent first requests.create_proxy_configuration()to the crawler as is,Noneincluded. The lock file updates crawlee to 1.11.2, the first version whose crawler options acceptproxy_configuration=Nonein type checking.[🤖] Claude Code using Opus 5.5
✍️ Drafted by Claude Code