Skip to content

fix: accept None for proxy_configuration in BasicCrawlerOptions - #2416

Merged
vdusek merged 1 commit into
masterfrom
fix/proxy-configuration-options-none
Nov 6, 2026
Merged

vdusek merged 1 commit into
masterfrom
fix/proxy-configuration-options-none

Conversation

@vdusek

@vdusek vdusek commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

BasicCrawler.__init__ takes proxy_configuration: ProxyConfiguration | None, but BasicCrawlerOptions types the field as ProxyConfiguration. Subclasses take their kwargs through that TypedDict, so BeautifulSoupCrawler(proxy_configuration=None) and the like fail type checking even though None works at runtime.

✍️ Drafted by Claude Code

@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Nov 6, 2026
@vdusek vdusek self-assigned this Nov 6, 2026
@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.21%. Comparing base (b71d5af) to head (6d38ee7).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2416      +/-   ##
==========================================
+ Coverage   94.19%   94.21%   +0.01%     
==========================================
  Files         184      184              
  Lines       13665    13665              
==========================================
+ Hits        12872    12874       +2     
+ Misses        793      791       -2     
Flag Coverage Δ
integration 76.62% <100.00%> (+0.02%) ⬆️
unit 85.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek requested review from Mantisus and Pijukatel November 6, 2026 12:41
@vdusek
vdusek marked this pull request as ready for review November 6, 2026 12:41

@apify-approval-mirror apify-approval-mirror Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring approval from @Mantisus.

@vdusek
vdusek merged commit 16858fd into master Nov 6, 2026
98 of 102 checks passed
@vdusek
vdusek deleted the fix/proxy-configuration-options-none branch November 6, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants