Repository navigation
fix: accept None for proxy_configuration in BasicCrawlerOptions - #2416
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2416 +/- ##
==========================================
+ Coverage 94.19% 94.21% +0.01%
==========================================
Files 184 184
Lines 13665 13665
==========================================
+ Hits 12872 12874 +2
+ Misses 793 791 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
November 6, 2026 12:41
Mantisus
approved these changes
Nov 6, 2026
Pijukatel
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BasicCrawler.__init__takesproxy_configuration: ProxyConfiguration | None, butBasicCrawlerOptionstypes the field asProxyConfiguration. Subclasses take their kwargs through that TypedDict, soBeautifulSoupCrawler(proxy_configuration=None)and the like fail type checking even thoughNoneworks at runtime.✍️ Drafted by Claude Code