Repository navigation
test(agent-isolation): keep the shim test's commit from signing - #1831
Merged
Merged
Conversation
test_a_linked_worktree_targets_the_main_checkout makes one commit in a throwaway repository, which picked up the developer's global commit.gpgsign. With a hardware signing key the commit waited for a touch and then failed, so the test failed locally while passing in CI. The commit now runs with commit.gpgsign=false. Generated-by: Claude Opus 5
potiuk
enabled auto-merge (squash)
October 25, 2026 20:27
github-actions
Bot
added
family:tools
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_a_linked_worktree_targets_the_main_checkoutmakes one commit in a throwaway repository.That commit picked up the developer's global
commit.gpgsign, so with a hardware signing key it waited for a touch and then failed: the test failed locally while passing in CI.The commit now runs with
-c commit.gpgsign=false; the repository has nothing to sign.Found while preparing #1829. The whole
test_hook_manager_shim.pysuite passes with a globalcommit.gpgsign=trueand a YubiKey-backed signing key.Generative AI disclosure: drafted with Claude Code (Claude Opus 5) and reviewed by the committer.
🤖 Generated with Claude Code