Repository navigation
fix(agent-isolation): arm the touch overlay for every git that reaches the key - #1833
Merged
Merged
Conversation
…s the key Commands that block on a touch still ran with no window when the matcher did not recognise them: git global options with a quoted value (-c user.name="Jane Doe"), git or ssh named by path or handed to a shell as a string, remote-talking git that is neither fetch nor push (lfs, archive --remote, subtree, svn, maintenance prefetch), and the gh commands that run git over ssh. Generated-by: Claude Opus 5
…fingerprint Generated-by: Claude Opus 5
potiuk
enabled auto-merge (squash)
October 25, 2026 23:02
potiuk
added a commit
that referenced
this pull request
Oct 28, 2026
* docs(spec-loop): sync specs with contributed functionality Back-fill the specs for the 46 commits since the last sync that changed behaviour without touching a spec: the public-surface scrub mod (#1676), adapter hardening (#1862), the hook managers with install strategy `none` (#1838), Linux `allowAllUnixSockets` and its socket cover (#1809), the touch-overlay dismissal and matcher (#1832, #1833), the per-family Codex manifests (#1836), Vulnogram reviewer comments (#1840), the verify false-pass fixes (#1808), gateway refusal hints (#1810), adversarial-review output and agy fixes (#1852, #1854, #1871), and code-review inline comment text (#1853). Also correct drift found on the way: the threat-model pointer now names Appendix B after the #1859 restructure, the troubleshooting catalogue has fourteen entries, and the overview's Mentoring and Pairing skill counts match docs/modes.md. Generated-by: Claude Opus 5 * docs(marketplace): magpie-security ships its own Codex manifest too #1676 gave magpie-security a .codex-plugin/plugin.json and an empty hooks/codex-hooks.json, because its hooks.json now carries a Claude Code mod, but the "Which manifest Codex reads" table and the Hooks paragraph still named only magpie-setup and magpie-utilities. Generated-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git -c user.name="Jane Doe" commit), one joined with=(--git-dir=/x), or one with a backslash-escaped quote (-c user.name=O\'Brien,-c user.name=$'O\'Brien')/usr/bin/git push,/opt/homebrew/bin/ssh host), quoted ("/usr/bin/git" push), or handed to a shell as a string (bash -c "git push",sh -c 'ssh host')fetchorpush:lfs,archive --remote,fetch-pack/send-pack,subtree,svn,maintenance run(its prefetch fetches),request-pullgit_protocol=ssh:gh repo clone,gh repo fork --clone,gh repo sync,gh pr createandgh repo create --push(they push a branch or repository not yet on GitHub),gh pr checkoutand its defaultcoalias (gh co,gh pr co), with options before or inside the command group (gh -R owner/repo pr checkout 1)~/.sshpaths,/etc/ssh/sshd_config,ssh-agent,sshuttle,gh pr view/gh repo view/gh pr comment(with or without-R),gh codespace, a script whose name only starts withgit-, and read-only git with a quoted-cvalue.Type of change
tools/*/withpyproject.toml)tools/agent-isolation/gpg-touch-overlay.shTest plan
tests/test_gpg_touch_overlay.py(93) and the full file pass on macOS and in a Linux container (python:3.12, bash 5.2).prek run --from-ref origin/mainpasses, as doestests/test_hook_manager_shim.pyafter mergingmain(which carries test(agent-isolation): keep the shim test's commit from signing #1831's fix for the shim test's signed commit).RFC-AI-0004 compliance
Notes for reviewers (optional)
Split from the dismissal fix in a separate PR, which keeps the window coming back. The two are independent and either can merge first.
🤖 Generated with Claude Code