FINERACT-2493: New command processing - execute job - #5952
Open
nidhiii128 wants to merge 1 commit into
Open
Conversation
nidhiii128
force-pushed
the
FINERACT-2493-execute-job
branch
from
June 7, 2026 12:53
cc7a91d to
67a59ed
Compare
Contributor
|
nidhiii128
force-pushed
the
FINERACT-2493-execute-job
branch
from
June 8, 2026 14:29
67a59ed to
7bfa1e9
Compare
Member
|
@nidhiii128 rebase and address failing checks |
nidhiii128
force-pushed
the
FINERACT-2493-execute-job
branch
4 times, most recently
from
June 16, 2026 08:55
165c83c to
8a6bd2d
Compare
6 tasks
Contributor
|
@nidhiii128 Please review the failing checks. |
nidhiii128
force-pushed
the
FINERACT-2493-execute-job
branch
from
June 27, 2026 11:57
8a6bd2d to
9b025e9
Compare
nidhiii128
marked this pull request as draft
July 23, 2026 18:54
nidhiii128
force-pushed
the
FINERACT-2493-execute-job
branch
from
July 23, 2026 19:29
9b025e9 to
883bfb4
Compare
nidhiii128
force-pushed
the
FINERACT-2493-execute-job
branch
from
August 1, 2026 07:41
883bfb4 to
1e617b4
Compare
nidhiii128
force-pushed
the
FINERACT-2493-execute-job
branch
7 times, most recently
from
August 15, 2026 10:10
9de1b12 to
c97a06b
Compare
nidhiii128
force-pushed
the
FINERACT-2493-execute-job
branch
from
August 15, 2026 12:27
c97a06b to
5830e21
Compare
nidhiii128
marked this pull request as ready for review
August 15, 2026 12:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the "execute job" REST endpoint (both by jobId and by short-name) from the legacy command-processing path to the new
fineract-commandframework. Cleans up dead code from the legacy execute-job path.Scope (PR 2 of 2 for FINERACT-2493)
JobExecuteRequest/JobExecuteResponsePOJOsJobExecuteCommandandJobExecuteCommandHandlerusingCommandHandler<REQ, RES>JobRegisterService.executeJobWithParameters(Long, Set<JobParameterDTO>)replacing the legacyStringJSON variantCommandDispatcherExecuteJobCommandHandlerand its testCommandWrapperBuilder.executeSchedulerJob()builder methodExecuteAllDirtyJobsTaskletto use the typedSet<JobParameterDTO>overloadSecurityConfigforPOST /api/*/jobs/*withEXECUTEJOB_SCHEDULERpermission?command=executeJobquery param still required, HTTP 202 response preserved, 405 short-circuit on non-batch mode preservedDesign choices (open to feedback)
List<JobParameterDTO>on the request rather than raw JSON.{ resourceId: jobId }returned insideResponse.status(202)for backward compatibility.Not in this PR
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.