FINERACT-2291: New command processing - update and delete group - #6015
FINERACT-2291: New command processing - update and delete group#6015nidhiii128 wants to merge 2 commits into
Conversation
e9cb5d5 to
4900905
Compare
|
Hi reviewers, quick note on the failing CI check: This is caused by the removal of @apiresponse(responseCode = "200", ...) annotations from the migrated controller methods, following the style guidance applied in prior reviews (Aleks flagged these as trivial/noisy in earlier PRs). Removing them drops the documented response schema from the OpenAPI spec, which swagger-brake then reports as a backward-incompatible change. I've gone with the style preference. The same expected failure pattern appears in the merged StaffCreateCommand migration reference. All 84 other checks are green: |
4900905 to
89d683c
Compare
|
@nidhiii128 Please resolve the conflicts and review the failing checks. |
89d683c to
792c489
Compare
|
@adamsaghy @vidakovic Please review |
792c489 to
3e01ff7
Compare
|
Thanks for the review. @vidakovic Directly flagged:
This PR now migrates update+delete+close to typed dispatch with zero JsonCommand in the Group service interface for these operations. |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
3e01ff7 to
b7ea812
Compare
Description
Migrates the "update group" (PUT
/v1/groups/{groupId}) and "delete group" (DELETE/v1/groups/{groupId}) REST endpoints from the legacy JSON-blob command-processing path to the new typed fineract-command framework.Scope (PR 2 of 3 for FINERACT-2291)
GroupUpdateRequest/GroupUpdateResponsePOJOs with Jakarta ValidationGroupDeleteRequest/GroupDeleteResponsePOJOsGroupUpdateCommand,GroupDeleteCommandand their corresponding handlers usingCommandHandler<REQ, RES>GroupingTypesWritePlatformServicegets new typedupdateGroup(GroupUpdateRequest)anddeleteGroup(GroupDeleteRequest)overloads. Legacy methods kept since they're still used byDeleteCenterCommandHandlerand other code paths.CommandDispatcherSecurityConfigforPUT /api/*/groups/*(UPDATE_GROUP) andDELETE /api/*/groups/*(DELETE_GROUP)commandGroupUpdateandcommandGroupDeleteValidationMessages.propertiesUpdateGroupCommandHandlerandDeleteGroupCommandHandlerdeleted@ApiResponse(200)and@RequestBodyswagger annotations on the migrated endpoints (return types are self-describing)Expected CI failure
run-api-backward-compatibilitywill fail due to removal of trivial@ApiResponse(200)annotations — same as PR #5952 (per @vidakovic's guidance).Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.