Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spark/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ under the License.
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-jdk18on</artifactId>
<version>1.78.1</version>
<version>1.85</version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above this dependency says "The version is the one Hadoop 3.4.1 builds with". That is 1.78.1 (bouncycastle.version in hadoop-project-3.4.1.pom), so with this bump the comment no longer holds. Could a maintainer either drop that sentence along with the bump, or keep the pin and ignore this update with @dependabot ignore this dependency? The jar only has to provide the class that Hadoop 3.4.1's KeyProvider links against, so either version should work for CometIcebergHdfsSuite, though I have not run it with 1.85.

<scope>test</scope>
</dependency>
</dependencies>
Expand Down
Loading