Repository navigation
build(deps-dev): bump org.bouncycastle:bcprov-jdk18on from 1.78.1 to 1.85 in /spark - #7595
Open
dependabot[bot] wants to merge 1 commit into
Open
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [org.bouncycastle:bcprov-jdk18on](https://github.com/bcgit/bc-java) from 1.78.1 to 1.85. - [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.md) - [Commits](https://github.com/bcgit/bc-java/commits) --- updated-dependencies: - dependency-name: org.bouncycastle:bcprov-jdk18on dependency-version: '1.85' dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
comphead
reviewed
Nov 11, 2026
comphead
left a comment
Contributor
There was a problem hiding this comment.
This dependency is test scope, in the spark-4.0 profile only, and exists so CometIcebergHdfsSuite can create a key provider on Hadoop 3.4.1.
| <groupId>org.bouncycastle</groupId> | ||
| <artifactId>bcprov-jdk18on</artifactId> | ||
| <version>1.78.1</version> | ||
| <version>1.85</version> |
Contributor
There was a problem hiding this comment.
The comment above this dependency says "The version is the one Hadoop 3.4.1 builds with". That is 1.78.1 (bouncycastle.version in hadoop-project-3.4.1.pom), so with this bump the comment no longer holds. Could a maintainer either drop that sentence along with the bump, or keep the pin and ignore this update with @dependabot ignore this dependency? The jar only has to provide the class that Hadoop 3.4.1's KeyProvider links against, so either version should work for CometIcebergHdfsSuite, though I have not run it with 1.85.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps org.bouncycastle:bcprov-jdk18on from 1.78.1 to 1.85.
Changelog
Sourced from org.bouncycastle:bcprov-jdk18on's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.