Skip to content

Show role names to non-members when references have no text #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amyjko merged 2 commits into from
Nov 7, 2026
Merged

Show role names to non-members when references have no text #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f2401d
Show the reference target to non-members when the text is empty.
amyjko Oct 5, 2026
ba104e2
Update v0.10.5 release date.
amyjko Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
We'll document all notable changes in this file, including bug fixes, enhancements, and dependency updates.
Dates should be in`YYYY-MM-DD` format and versions are in [semantic versioning](http://semver.org/) format.

## v0.10.5 2026-11-07

### Fixed

- Role names no longer appear blank on process pages for people who aren't logged in.

## v0.10.4 2026-10-05

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "adminima",
"version": "0.10.4",
"version": "0.10.5",
"private": true,
"scripts": {
"dev": "vite dev",
Expand Down
5 changes: 3 additions & 2 deletions src/lib/ReferenceView.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@
{:else if process}
<ProcessLink {process} />
{:else if !context().member}
<!-- Non-members may not be able to see the org's roles, so just show the text the author wrote. -->
{segment.text}
<!-- Non-members may not be able to see the org's roles, so just show the text the author wrote,
or the target if they didn't write any, as in <@AOM>. -->
{segment.text.length > 0 ? segment.text : segment.target}
{:else}
<!-- Say so, rather than rendering a link that silently goes nowhere. -->
<Oops inline text="Unknown role or process: {segment.target}" />
Expand Down
Loading