Repository navigation
Show role names to non-members when references have no text - #35
Merged
Merged
Conversation
References are often written without text, as in <@aom>. RoleLink shows the role's title, so members never noticed, but #34 showed non-members segment.text, which rendered as a blank. Fall back to the target. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #34 deployed, logged-out visitors to
/org/uwischool/process/TeachingEvaluationssee blanks where role names should be: "Each year, the notifies faculty…".#34 showed non-members a reference's text. But references are often written with no text: all 25 role references in that process are
<@AOM>,<@ADA>and so on, which is also what pasting produces. Members never saw this becauseRoleLinkshows the role's title, not the text.Change
ReferenceView.svelte: for non-members, show the text if there is any, otherwise the target.Testing
On the local stack, I loaded a step reading
Each year, the <@AOM> notifies faculty. Ask the <bogus@NOPE> for help.:<@AOM>onmain<@AOM>with this change<bogus@NOPE>AOMbogusAOMbogusNo hydration warnings or errors for any viewer.
svelte-check: 0 errors. Unit tests: 288 passed.🤖 Generated with Claude Code