Repository navigation
Conversation
…i 5.2 both declare containSubset Co-Authored-By: Claude Opus 5.5 <[email protected]>
… per-browser preference Co-Authored-By: Claude Opus 5.5 <[email protected]>
…tore Co-Authored-By: Claude Opus 5.5 <[email protected]>
…in three modes Co-Authored-By: Claude Opus 5.5 <[email protected]>
… match the v1 Tailwind root Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
…t it Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ercase letters only Co-Authored-By: Claude Opus 5.5 <[email protected]>
…heme mapping and the focus utility Co-Authored-By: Claude Opus 5.5 <[email protected]>
…so biome ci passes src/v1/styles/tokens.css is written by scripts/build-v1-tokens.mjs and checked byte-for-byte by styles/tokens.test.ts; the formatter would rewrap it and break the check. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
…sts and on missing variants Co-Authored-By: Claude Opus 5.5 <[email protected]>
…and portal sync Co-Authored-By: Claude Opus 5.5 <[email protected]>
…tEffect Co-Authored-By: Claude Opus 5.5 <[email protected]>
…line styles, CSS imports and !important fail lint Co-Authored-By: Claude Opus 5.5 <[email protected]>
… arbitrary values Co-Authored-By: Claude Opus 5.5 <[email protected]>
… and the fixtures v0's root auto-detected sources across the whole frontend, so the v1 tree, scripts/check-v1-styles.mjs and test-fixtures/ added 12 unprefixed utilities and 8 theme variables to v0's stylesheet. With these three @source not lines the v0 build is byte-identical to the base again (239/239 files). Co-Authored-By: Claude Opus 5.5 <[email protected]>
…longer cancel each other Co-Authored-By: Claude Opus 5.5 <[email protected]>
…our arbitrary values and !important after a variant Co-Authored-By: Claude Opus 5.5 <[email protected]>
…cope variants, shadows and the root fill to v1 Co-Authored-By: Claude Opus 5.5 <[email protected]>
…the theme test exercises the mode effect Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ge, the pixel escape and the current unprefixed-class rationale Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Fable 5.1 <[email protected]>
…to UN-4290-v1-menus-tokens # Conflicts: # frontend/package.json # frontend/src/v1/tsconfig.json
Every utility is ui:-prefixed and reads a P0-T04 token: colours, type roles, radius, shadow, scrim. Menus and the switch dialog portal into #v1-portal, where the tokens are defined. Organisation avatars use one token pair until the tokens carry an avatar palette. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Runtime geometry (a page's aspect ratio, a highlight's position) cannot be a token or a class. Rule S1 now accepts a style attribute whose value is an object literal with only "--name" keys, so the numbers travel through custom properties that ui: classes read (ui:aspect-(--page-aspect)); a string, a variable, a spread or a plain key still fails. Three fixtures pin it. Co-Authored-By: Claude Fable 5.1 <[email protected]>
pre-commit's check-shebang-scripts-are-executable fails on branches stacked on this one; check-v1.mjs already carries the bit. Co-Authored-By: Claude Fable 5.1 <[email protected]>
React's CSSProperties has no index signature for "--*" keys, so the object literal rule S1 allows fails TS2353 under strict mode. Augment it under lib/, and typecheck the passing fixture so the augmentation is exercised. Raised by Ali on the viewer stack. Co-Authored-By: Claude Fable 5.1 <[email protected]>
# Conflicts: # frontend/src/v1/shell/OrganizationSwitcher.tsx # frontend/src/v1/tsconfig.json
…to UN-4290-v1-menus-tokens
The scroll fix arrived from the menus branch with unprefixed class names; the token port renames them. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The hint's leading space sat inside the hidden span, where JSX
whitespace rules decide whether it is read. An explicit {" "} keeps
the accessible name "Help & docs (opens in a new tab)".
Co-Authored-By: Claude Opus 5.5 <[email protected]>
…her frames The account menu and the switch dialog used the sidebar colour, which is navy in the Unstract theme under dark text. Both now use the popover colour. The Switch button gets the frame's ArrowRightLeft icon and 14px text, Cancel gets 14px padding, "Nothing to switch to." uses the caption style, and the dialog description sits 4px above the from/to box (frames O01 to O03). Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ui:prefix, and colours, type, radius and shadows come from the token utilities.getPortalContainer().Why
ui:prefix, the tokens and a style lint that rejects raw colours and pixel values. The menus from UN-4290 [FEAT] Add the v1 account menu and organisation switcher #2395 fail that lint once UN-4299 [FEAT] v1 design tokens, themes and style isolation (P0-T04) #2399 lands..v1[data-theme], so a Radix portal attached todocument.bodyrenders without them.How
ui:class with@tailwindcss/node(0 classes that produce no CSS).primary-muted/primary). The frames rotate five colours, and the tokens have no avatar palette yet.bg-scrim, and the current row usesbg-muted.Can this PR break any existing features? If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
bun run typecheck:v1,bun run lint:v1(includingcheck-v1-styles.mjs) andbun run test:v1: 119 vitest tests and 66 fixture tests pass.Screenshots
Checklist
I have read and understood the Contribution Guidelines.
🤖 Generated with Claude Code