UN-4290 [FEAT] Add the v1 account menu and organisation switcher by athul-rs · Pull Request #2395 · Zipstack/unstract

athul-rs · 2026-10-28T06:37:16Z

What

The v1 account menu and organisation switcher (P2-T02, pages 01 and 19).
Account menu: name and e-mail, Profile & preferences, Help & docs, Sign out, and a account-menu.plan-billing slot that cloud fills.
Organisation switcher: the user's organisations with role, member count and region (from PB-T15), search, and a confirm step before switching.

Why

P2-T02 (UN-4290). The logout API change for this ticket merged as UN-4290 [FEAT] Accept POST on /logout #2364; this is the frontend half.

How

Sign out calls POST /logout, resets analytics and opens the URL the backend returns (the identity provider's logout). If the POST fails it falls back to the GET logout, which still ends the session.
A user with no name sees the e-mail once, as the title line.
lib/http.ts is a small axios client with the CSRF header. It is a stand-in for P0-T05 (UN-4313, the shared HTTP client) and is replaced when that lands.
Styling uses v0's CSS variables for now and moves to the P0-T04 tokens (and their #v1-portal container) when those land.

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

No. All files are new and under frontend/src/v1/; nothing in v0 imports them, and no route renders them until the v1 shell (P2-T01) mounts them.

Database Migrations

None.

Env Config

None.

Relevant Docs

Design: frames NEW09 (account menu), O01 to O04 (switcher, confirm, single organisation, member), designs repo at 83e4fff.
Deferred, with owners: create organisation (the plan rule that forbids it is undecided); avatar photo; region labels (codes are shown as the backend sends them).

Related Issues or PRs

UN-4290 (P2-T02), epic UN-4257. Base: UN-4286 [FEAT] Add the v1 plugin manifest, slots and build check #2394 (UN-4286, plugin slots), which sits on UN-4270 [FEAT] v1 scaffold, strict TypeScript and import boundary #2380 (scaffold). Merge order: UN-4270 [FEAT] v1 scaffold, strict TypeScript and import boundary #2380, UN-4286 [FEAT] Add the v1 plugin manifest, slots and build check #2394, this PR. Backend: UN-4283 [FEAT] Add role, member count and region to the organisation list #2361 (organisation list), UN-4290 [FEAT] Accept POST on /logout #2364 (logout POST).

Dependencies Versions

None.

Notes on Testing

bun run typecheck:v1, lint:v1, test:v1: clean, 82 vitest tests.
Frontend CI (typecheck, vitest, biome) runs once this PR targets main, i.e. after UN-4270 [FEAT] v1 scaffold, strict TypeScript and import boundary #2380 and UN-4286 [FEAT] Add the v1 plugin manifest, slots and build check #2394 merge. The commands above were run locally.
Tested in a dev namespace (before the rebase onto UN-4270 [FEAT] v1 scaffold, strict TypeScript and import boundary #2380) against a real backend, through a test-branch-only preview route: real organisations with role, member count and region; confirm then switch; search; sign out ending on /landing with the session gone (after unstract-cloud#1899). No console errors.

Screenshots

To add from the dev run.

Checklist

I have read and understood the Contribution Guidelines.

🤖 Generated with Claude Code

P2-T02 (pages 01 and 19). The account menu from the avatar: identity, Profile & preferences, the account-menu.plan-billing slot for cloud, Help & docs and Sign out. Sign out POSTs /api/v1/logout with the CSRF token, resets analytics and opens the returned URL; if the POST fails it falls back to the GET logout. No "Switch to old version" item (D14). The organisation switcher from the pill: search, a row per organisation with role, member count and region (absent fields left out), the current one marked, a confirmation before switching, the one-organisation and member states, and a load error with retry. After a switch the app does a full load of the same section in the new organisation, else its dashboard. Create organisation is left for a decision (plan gap 6). lib/http.ts is the shared client: session cookie, X-CSRFToken on unsafe methods. Invisible until the shell (P2-T01) renders these components. Co-Authored-By: Claude Opus 5.5 <[email protected]>

… has no name Found on the dev preview: a user without a name got an empty title line above the e-mail. Co-Authored-By: Claude Opus 5.5 <[email protected]>

…e and guard the CSRF cookie signOut now throws when the reply has no redirect URL so the GET logout fallback runs. signOutAndLeave in services/session.ts owns the whole sequence (POST, analytics reset, navigate, fallback) and AccountMenu calls it. A malformed CSRF cookie sends no header instead of throwing. The account trigger shows one letter, and the Help & docs link announces that it opens in a new tab. Co-Authored-By: Claude Opus 5.5 <[email protected]>

A switch in flight can no longer be cancelled, a 412 from the list sends the user to sign-in, an empty search says so, the dialog's from side comes from the current organisation, and overlapping list loads keep only the latest. The loading text is a live region and the current row carries aria-current. The Switch button gets the arrows icon, and avatars show two letters for a one-word name while the pill shows one. Co-Authored-By: Claude Opus 5.5 <[email protected]>

Co-Authored-By: Claude Opus 5.5 <[email protected]>

greptile-apps · 2026-10-28T07:08:56Z

via Greptile

Confidence Score: 5/5

[Medium impact] No blocking issue remains, with the two earlier theme findings addressed by dependent PR #2402.

Summary

Adds the v1 account menu, organisation search and confirmed switching, plus shared HTTP and sign-out helpers.

People can search and confirm before changing organisations.
People can open account details and sign out from the v1 menu.

Review used source and test inspection. No tests or browser checks were run; neither menu has a production route yet.

_{Reviews (3) · Last reviewed commit: "Merge branch 'UN-4286-plugin-manifest' i..." · Reviewed by Greptile}

greptile-apps · 2026-10-28T07:09:00Z

+                      <li
+                        key={org.id}
+                        {...(isCurrent ? { "aria-current": "true" } : {})}
+                        className={`flex h-14 items-center gap-2.5 rounded-lg px-2.5 ${isCurrent ? "bg-[#f5f5fa]" : ""}`}


Current row fades in darkness

The current organisation row always uses the light background #f5f5fa, but OrgLine uses --foreground, which becomes near-white in dark mode. This makes the organisation's name hard to read. Use a theme-aware background for this row.

Suggested change

className={`flex h-14 items-center gap-2.5 rounded-lg px-2.5 ${isCurrent ? "bg-[#f5f5fa]" : ""}`}

className={`flex h-14 items-center gap-2.5 rounded-lg px-2.5 ${isCurrent ? "bg-[var(--muted)]" : ""}`}

Prompt To Fix With AI

This is a comment left during a code review. Path: frontend/src/v1/shell/OrganizationSwitcher.tsx Line: 307 Comment: **Current row fades in darkness** The current organisation row always uses the light background `#f5f5fa`, but `OrgLine` uses `--foreground`, which becomes near-white in dark mode. This makes the organisation's name hard to read. Use a theme-aware background for this row. ```suggestion className={`flex h-14 items-center gap-2.5 rounded-lg px-2.5 ${isCurrent ? "bg-[var(--muted)]" : ""}`} ``` --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Valid on this branch alone. The token port that follows #2399 moves the current row to bg-muted and defines --primary-muted in all three themes. Leaving this open until it lands.

greptile-apps · 2026-10-28T07:09:00Z

+          className="z-50 flex w-[280px] flex-col gap-0.5 rounded-[10px] border border-[var(--border)] bg-[var(--sidebar)] p-1.5 shadow-[0_8px_24px_0_#0000001f]"
+        >
+          <div className="flex items-center gap-2.5 px-[9px] pt-1.5 pb-2">
+            <span className="flex size-9 shrink-0 items-center justify-center rounded-full bg-[var(--primary-muted)] text-[13px] font-semibold text-[var(--primary)]">


Avatar and badge backgrounds disappear

--primary-muted is not defined in the frontend styles. The account avatar, switch dialog icon and Current badge therefore lose their intended background. Use an existing colour variable or provide a fallback until the v1 colours land.

Prompt To Fix With AI

This is a comment left during a code review. Path: frontend/src/v1/shell/AccountMenu.tsx Line: 69 Comment: **Avatar and badge backgrounds disappear** `--primary-muted` is not defined in the frontend styles. The account avatar, switch dialog icon and Current badge therefore lose their intended background. Use an existing colour variable or provide a fallback until the v1 colours land. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Valid on this branch alone. The token port that follows #2399 moves the current row to bg-muted and defines --primary-muted in all three themes. Leaving this open until it lands.

…ins in the ignore check (UN-4270) Reported by Athul while building #2394/#2395 on this branch: - src/v1/tsconfig.json: skipLibCheck back on, as in tsconfig.json. Off, tsc also checked third-party typings, and @types/chai 5.2.3 and vitest 3.2.6 both declare `containSubset`, so any v1 test importing vitest failed typecheck:v1. A fixture test now imports vitest to keep this covered. - The "no v1 file is git-ignored" check skips src/v1/plugins/<id>/: cloud plugins copied there are git-ignored on purpose (#2394).

…o the viewport The popover had no height limit, so with many organisations the rows ran past the bottom of a short window. The panel now takes Radix's measured available height (8px collision padding) and only the list scrolls, so the search box stays in view. Co-Authored-By: Claude Opus 5.5 <[email protected]>

sonarqubecloud · 2026-10-29T14:57:39Z

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

athul-rs and others added 7 commits October 27, 2026 18:05

UN-4290 [FIX] Show the e-mail as the account menu title when the user…

e7d4b55

… has no name Found on the dev preview: a user without a name got an empty title line above the e-mail. Co-Authored-By: Claude Opus 5.5 <[email protected]>

UN-4290 [CHORE] Merge the P0-T07 review fixes

b3e8acf

Co-Authored-By: Claude Opus 5.5 <[email protected]>

UN-4290 [CHORE] Merge the P0-T07 loader fix

52c4f55

Co-Authored-By: Claude Opus 5.5 <[email protected]>

UN-4290 [FIX] Follow only an http(s) sign-out redirect

3b11ca4

Co-Authored-By: Claude Opus 5.5 <[email protected]>

athul-rs mentioned this pull request Oct 28, 2026

UN-4286 [FEAT] Add the v1 plugin manifest, slots and build check #2394

Open

athul-rs marked this pull request as ready for review October 28, 2026 07:06

athul-rs requested review from hari-kuriakose, jaseemjaskp, ritwik-g and vishnuszipstack October 28, 2026 07:06

greptile-apps Bot reviewed Oct 28, 2026

View reviewed changes

athul-rs added a commit that referenced this pull request Oct 28, 2026

Test branch: merge UN-4290-v1-account-menu (#2395, with #2394)

8386d92

athul-rs mentioned this pull request Oct 28, 2026

UN-4290 [FEAT] Move the v1 menus onto design tokens #2402

Draft

greptile-apps Bot approved these changes Oct 29, 2026

View reviewed changes

Merge branch 'UN-4286-plugin-manifest' into UN-4290-v1-account-menu

5e944c3

Navigation Menu

Repository navigation

UN-4290 [FEAT] Add the v1 account menu and organisation switcher - #2395

UN-4290 [FEAT] Add the v1 account menu and organisation switcher#2395
athul-rs wants to merge 9 commits into
UN-4286-plugin-manifestfrom
UN-4290-v1-account-menu

athul-rs commented Oct 28, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Oct 28, 2026 •

edited

Loading

Summary

Uh oh!

Uh oh!

greptile-apps Bot Oct 28, 2026

Uh oh!

athul-rs Oct 29, 2026

Uh oh!

greptile-apps Bot Oct 28, 2026

Uh oh!

athul-rs Oct 29, 2026

Uh oh!

sonarqubecloud Bot commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	className={`flex h-14 items-center gap-2.5 rounded-lg px-2.5 ${isCurrent ? "bg-[#f5f5fa]" : ""}`}
	className={`flex h-14 items-center gap-2.5 rounded-lg px-2.5 ${isCurrent ? "bg-[var(--muted)]" : ""}`}

Conversation

athul-rs commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

How

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

Database Migrations

Env Config

Relevant Docs

Related Issues or PRs

Dependencies Versions

Notes on Testing

Screenshots

Checklist

Uh oh!

greptile-apps Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

greptile-apps Bot Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

athul-rs Oct 29, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 28, 2026

Choose a reason for hiding this comment

Uh oh!

athul-rs Oct 29, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Oct 29, 2026

Quality Gate passed

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

athul-rs commented Oct 28, 2026 •

edited

Loading

greptile-apps Bot commented Oct 28, 2026 •

edited

Loading